Univention Bugzilla – Bug 43509
dijitHidden changed and is now using visibility: hidden instead of display: none
Last modified: 2017-04-04 18:29:27 CEST
Our code uses the dijitHidden class but that class changed and should only be used by dijit. We need to change everything that uses dijitHidden to use something that is setting display: none instead.
There is a new class dijitDisplayNone which can be used!
(In reply to Florian Best from comment #1) > There is a new class dijitDisplayNone which can be used! *lol* new... 10 years old ;) ... https://github.com/dojo/dijit/blame/master/themes/dijit.css#L162 From Bug 32037, comment 24: > The height of the body? does not change after changing a module. > After scrolling through a long list and clicking on the home button, the > page is still as long as the list.
Just observed the following behaviour which also has to do something with this: * Open the "App Center" module * Open the "Computer" module → the scrollbar from the "App Center" module persists * Add a new computer * When clicking on "Next", the scrollbar jumps down and I have to click a 2nd time on "Next".
univention-web (1.0.32-1): r77520 | Bug #43509: dijitHidden → dijitDisplayNone univention-updater (12.0.4-1): r77514 | Bug #43509: dijitHidden → dijitDisplayNone univention-management-console-module-udm (7.0.8-1): r77518 | Bug #43509: dijitHidden → dijitDisplayNone univention-management-console (9.0.54-1): r77522 | Bug #43509: dijitHidden → dijitDisplayNone univention-app-appliance (1.0.2-1): r77511 | Bug #43509: dijitHidden → dijitDisplayNone univention-system-setup (10.0.8-1): r77513 | Bug #43509: dijitHidden → dijitDisplayNone univention-self-service (2.0.9-2): r77523 | Bug #43509: dijitDisplayNone → dijitDisplayNone univention-cloud-init (4.0.2-1): r77521 | Bug #43509: dijitHidden → dijitDisplayNone univention-printserver (10.0.1-1): r77517 | Bug #43509: dijitHidden → dijitDisplayNone univention-pkgdb (10.0.1-1): r77516 | Bug #43509: dijitHidden → dijitDisplayNone univention-appcenter (6.0.2-1): r77515 | Bug #43509: dijitHidden → dijitDisplayNone univention-portal (1.0.8-1): r77524 | Bug #43509: dijitHidden → dijitDisplayNone univention-system-activation (2.0.2-1): r77512 | Bug #43509: dijitHidden → dijitDisplayNone
Please revert these changes. We should just add "display: none !important;" in, e.g., document.styl to .dijitHidden instead of changing our code. ATM, a dialog with a StackContainer (e.g., the StatupDialog) is broken from the second page on (ucr set umc/web/startupdialog=true).
For now it seems that re-using dijitHidden in umc/widgets/Wizard::_getMaxHeight() fixes this bug. univention-web (1.0.33-3): r77545 | Bug #43509: Use dijitHidden instead of dijitDisplayNone in Wizard
What I tested so far: I used the umc and didn't see any related errors. Checked a wizard. No scrollbar persist.
I think we can set this bug to VERIFIED. If there are problems, these will be revealed during the product tests.
UCS 4.2 has been released: https://docs.software-univention.de/release-notes-4.2-0-en.html https://docs.software-univention.de/release-notes-4.2-0-de.html If this error occurs again, please use "Clone This Bug".