Univention Bugzilla – Bug 45307
umc/module/timeout has no effect anymore
Last modified: 2017-09-06 17:10:12 CEST
Created attachment 9160 [details]
Since Bug #44965 the UMC module timeout of 600 seconds is not effective anymore if there are no active/pending requests.
Instead the connection timeout of 30 seconds stops the module process prior.
This shouldn't be a problem in the real world but the configuration is useless then.
Additionally if a request takes longer than 30 seconds, then after the response is send to the client the module process closes/ends immediately. This might be more a problem if e.g. the module process expects that after that request another request comes which needs data from the current module process.
I think we should evaluate the connection timeout after the response instead of at the start of the request.
Attached is a patch which fixes both problems.
Note: For Bug #44965 the connection timeout is only needed for the connection between UMC-Webserver and UMC-Server, not between UMC-Server and UMC-Moduleprocess.
+++ This bug was initially created as a clone of Bug #44965 +++
After opening many umc-modules I was not able to login to the umc anymore. I got a traceback (see screenshot.png).
Restarting the webserver solved the problem.
@Dirk: This might also be the problem why two of the App-Center UMC Jenkins tests are currently failing:
Workaround: ucr set 'umc/server/connection-timeout'=600
r82577 | Bug #45307: fix umc/module/timeout
Merge to UCS 4.2-2:
r82579 | Bug #45307: fix umc/module/timeout
r82580 | YAML Bug #45307
* The intended behaviour for Bug 44965 that inactive connections are cleaned up
still works correctly.
* The timeout for module processes is respected properly.
YAML file: OK
BTW ... please commit also these changes to 4.2-2!
See comment #3, there is the merge mentioned.
I cherry-picked and built the package for the 4.2-2 scope.
As the package had been built for the 4.2-2 scope, I added an entry to the changelog.
r82667 | Bug #45307, Bug #45280: added changelog entry