Bug 45491 - Styling for Calendar widget is broken
Styling for Calendar widget is broken
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC (Generic)
UCS 4.2
Other Linux
: P5 normal (vote)
: UCS 4.2-2-errata
Assigned To: Johannes Keiser
Florian Best
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2017-10-05 18:54 CEST by Johannes Keiser
Modified: 2017-10-10 15:38 CEST (History)
1 user (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 1: Cosmetic issue or missing function but workaround exists
Who will be affected by this bug?: 4: Will affect most installed domains
How will those affected feel about the bug?: 1: Nuisance – not a big deal but noticeable
User Pain: 0.023
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Ticket number:
Bug group (optional): Design
Max CVSS v3 score:
keiser: Patch_Available+


Attachments
Calendar_styling__old_and_new (37.02 KB, image/png)
2017-10-05 18:54 CEST, Johannes Keiser
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Johannes Keiser univentionstaff 2017-10-05 18:54:41 CEST
Created attachment 9240 [details]
Calendar_styling__old_and_new

The structure of the dijit/Calendar widget changed (probably with the update to dojo 1.12 Bug #42291) and the old styling is therefore broken.
Comment 1 Johannes Keiser univentionstaff 2017-10-05 19:00:25 CEST
Patch: https://git.knut.univention.de/univention/ucs/tree/jkeiser/bug_45491__calendar_styling

See screenshot.

This patch also adds a textbox to the calendar to make selecting far off years easier
Comment 2 Johannes Keiser univentionstaff 2017-10-09 14:19:12 CEST
2f376a8 Bug #45491: Adjust styling for Calendar widget
796bf9c Bug #45491: Add inputfield for the year to Calendar widget
3fbf3a2 Bug #45491: Adjust styling for year input of the Calendar widget
18461e4 Bug #45491: Improve tabhandling for DateBox/Calendar Widget
00d99f7 Bug #45491: Add navigation tooltip to Calendar
1b89761 Bug #45491: Debian changelog entry
b1476ee Bug #45491: Merge branch 'jkeiser/bug_45491__calendar_styling' into 4.2-2
271a694 Bug #45491: YAML
Comment 3 Johannes Keiser univentionstaff 2017-10-09 14:20:21 CEST
univention-web (1.0.42-47):

(In reply to Johannes Keiser from comment #2)
> 2f376a8 Bug #45491: Adjust styling for Calendar widget
> 796bf9c Bug #45491: Add inputfield for the year to Calendar widget
> 3fbf3a2 Bug #45491: Adjust styling for year input of the Calendar widget
> 18461e4 Bug #45491: Improve tabhandling for DateBox/Calendar Widget
> 00d99f7 Bug #45491: Add navigation tooltip to Calendar
> 1b89761 Bug #45491: Debian changelog entry
> b1476ee Bug #45491: Merge branch 'jkeiser/bug_45491__calendar_styling' into
> 4.2-2
> 271a694 Bug #45491: YAML
Comment 4 Johannes Keiser univentionstaff 2017-10-09 17:25:57 CEST
f7c44a8 Bug #45491: Fix typo
5ead8d5 Bug #45491: YAML
Comment 5 Florian Best univentionstaff 2017-10-10 14:49:51 CEST
Well, the patch does more than fixing the styling. It adds keyboard shortcuts which can be make visible by pressing "?".

In Internet Explorer 11 if you enter "56" as year it will display a lot of "NaN" and "undefined". It is also possible to enter negative years.
Firefox and Chromium are OK.

Also the background color differs when hovering one day and selecting via the keyboard cursors another day.

But I think the general behavior & design improved and we need to release the errata updates.

OK: YAML
Comment 6 Arvid Requate univentionstaff 2017-10-10 15:38:53 CEST
<http://errata.software-univention.de/ucs/4.2/195.html>