Bug 45550 – (4.2) ucs-school-import: ImportUser.make_email() does not honor config[mandatory_attributes]

Bug 45550 - (4.2) ucs-school-import: ImportUser.make_email() does not honor config[mandatory_attributes]


Summary:	(4.2) ucs-school-import: ImportUser.make_email() does not honor config[mandat...

Status:	CLOSED FIXED

Product:	UCS@school
Classification:	Unclassified
Component:	Import scripts
Version:	UCS@school 4.2
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS@school 4.2 v5
Assigned To:	Daniel Tröder
QA Contact:	Sönke Schwardt-Krummrich

URL:
Keywords:

Depends on:	42503
Blocks:	45553
	Show dependency tree / graph

Reported:	2017-10-17 10:30 CEST by Daniel Tröder
Modified:	2017-10-18 17:13 CEST (History)
CC List:	1 user (show)

See Also:
What kind of report is it?:	Bug Report
What type of bug is this?:	3: Simply Wrong: The implementation doesn't match the docu
Who will be affected by this bug?:	3: Will affect average number of installed domains
How will those affected feel about the bug?:	4: A User would return the product
User Pain:	0.206
Enterprise Customer affected?:
School Customer affected?:	Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Daniel Tröder

2017-10-17 10:30:42 CEST

+++ This bug was initially created as a clone of Bug #42503 +++

ImportUser.make_email() raises an exception if no email address is either supplied in the input data or can be created from a scheme.

It ignores config[mandatory_attributes]: if there is no "email" in the list, no exception should be raised, but the attribute should be left empty.

---------------

As a result of Bug #44993 this now happened again at a customer in unique_email_handler.format_name().

Comment 1 Daniel Tröder

2017-10-17 11:06:05 CEST

[4.2 6f8415ed] ImportUser.make_email() now honors config[mandatory_attributes] again

ucs-school-import 15.0.2-4A~4.2.0.201710171032

Comment 2 Daniel Tröder

2017-10-17 13:03:50 CEST

[4.2 04cae196] advisory

Comment 3 Daniel Tröder

2017-10-18 15:19:40 CEST

c9dfcec6 : reverted a typo introduced in 6f8415ed

ucs-school-import 15.0.2-5

Comment 4 Sönke Schwardt-Krummrich

2017-10-18 15:58:39 CEST

OK: code change
OK: functional test (jenkins reports no new errors and test at affected customer was successful)
~OK: advisory

Comment 5 Sönke Schwardt-Krummrich

2017-10-18 17:13:15 CEST

UCS@school 4.2 v5 has been released.

http://docs.software-univention.de/changelog-ucsschool-4.2v5-de.html

If this error occurs again, please clone this bug.