Bug 45553 – (4.1r2) ucs-school-import: ImportUser.make_email() does not honor config[mandatory_attributes]

Bug 45553 - (4.1r2) ucs-school-import: ImportUser.make_email() does not honor config[mandatory_attributes]


Summary:	(4.1r2) ucs-school-import: ImportUser.make_email() does not honor config[mand...

Status:	CLOSED FIXED

Product:	UCS@school
Classification:	Unclassified
Component:	Import scripts
Version:	UCS@school 4.1 R2
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS@school 4.1 R2 v15
Assigned To:	Daniel Tröder
QA Contact:	Sönke Schwardt-Krummrich

URL:
Keywords:

Depends on:	42503 45550
Blocks:
	Show dependency tree / graph

Reported:	2017-10-17 12:47 CEST by Daniel Tröder
Modified:	2017-10-18 17:13 CEST (History)
CC List:	1 user (show)

See Also:
What kind of report is it?:	Bug Report
What type of bug is this?:	3: Simply Wrong: The implementation doesn't match the docu
Who will be affected by this bug?:	3: Will affect average number of installed domains
How will those affected feel about the bug?:	4: A User would return the product
User Pain:	0.206
Enterprise Customer affected?:
School Customer affected?:	Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Daniel Tröder

2017-10-17 12:47:54 CEST

+++ This bug was initially created as a clone of Bug #45550 +++

+++ This bug was initially created as a clone of Bug #42503 +++

ImportUser.make_email() raises an exception if no email address is either supplied in the input data or can be created from a scheme.

It ignores config[mandatory_attributes]: if there is no "email" in the list, no exception should be raised, but the attribute should be left empty.

---------------

As a result of Bug #44993 this now happened again at a customer in unique_email_handler.format_name().

Comment 1 Daniel Tröder

2017-10-17 13:02:31 CEST

Cherry picked 6f8415eda8a67724ab8caefc3bbea00b334e4f24 from 4.2 to 4.1r2:

[4.1r2 0c26711e] (4.1r2) ImportUser.make_email() now honors config[mandatory_attributes] again
[4.1r2 42c21b25] advisory

ucs-school-import 14.0.16-49.340.201710171258

Comment 2 Daniel Tröder

2017-10-18 16:01:52 CEST

c46ee622: fixed typo
4aaae419: advisory update

ucs-school-import 14.0.16-50

Comment 3 Sönke Schwardt-Krummrich

2017-10-18 17:12:23 CEST

OK: code change
OK: functional test
~OK: advisory

Comment 4 Sönke Schwardt-Krummrich

2017-10-18 17:13:01 CEST

UCS@school 4.1 R2 v15 has been released.

http://docs.software-univention.de/changelog-ucsschool-4.1R2v15-de.html

If this error occurs again, please clone this bug.