Bug 46102 - UCS 4.3: Remove Cyrus integration
UCS 4.3: Remove Cyrus integration
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: Mail
UCS 4.3
Other Linux
: P5 normal (vote)
: UCS 4.3
Assigned To: Daniel Tröder
Sönke Schwardt-Krummrich
: interim-2
: 45466 (view as bug list)
Depends on: 46073 46454
Blocks: 46112
  Show dependency treegraph
 
Reported: 2018-01-22 08:59 CET by Daniel Tröder
Modified: 2021-05-11 14:57 CEST (History)
1 user (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 2: Improvement: Would be a product improvement
Who will be affected by this bug?: 2: Will only affect a few installed domains
How will those affected feel about the bug?: 2: A Pain – users won’t like this once they notice it
User Pain: 0.046
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Tröder univentionstaff 2018-01-22 08:59:38 CET
Simplify the UCS maintenance by removing the UCS-Cyrus-integration.

* remove source packages univention-mail-cyrus and univention-mail-cyrus-murder
* remove source package univention-mail-cyrus-ox
* remove binary packages from 4.3-0 and 4.3/oxseforucs repositories
* remove Cyrus-related integration source code from other packages (like univention-mail-postfix, univention-spamassassin etc) and apps
Comment 1 Daniel Tröder univentionstaff 2018-01-23 08:44:41 CET
Please change the status of various Cyrus-related bugs to WONTFIX (e.g. Bug #37187).
Comment 2 Daniel Tröder univentionstaff 2018-01-23 10:44:35 CET
The 4.3 pre_up script will block updates if univention-mail-cyrus is found and display a link to an article: Bug #46112.
Comment 3 Daniel Tröder univentionstaff 2018-01-23 16:02:56 CET
Work in branch "dtroeder/46102_remove_cyrus" of repository ucs:

bb538ca3: remove univention-mail-cyrus
2d56244d: remove univention-mail-cyrus-murder
8eeb6820: remove translations for univention-mail-cyrus
552ae15c: remove cyrus specific tests
0c48447d: remove cyrus specific test
965811cd: remove translations for univention-mail-cyrus
5011de68: remove test code branches for cyrus
c2b115c6: changelog
5418a342: remove cyrus related code from univention-mail-postfix
47d3ad70: changelog
c098fdd7: remove cyrus related code from univention-spamassassin
55bbf608: fix description
ce42d2fd: copyright
4c3958da: remove documentation on Cyrus integration
295b0569: remove support for Cyrus from ACL test

Work in branch "4.3" of repository appsuite:

cf08b8dd: create 4.3 branch of OX integration
0de2ee3b: copyright
8c3ee874: remove univention-mail-cyrus-ox
20d19d24: remove cyrus related code

The build system currently cannot build for 4.3, so I'll test this in a VM for now.

Prior to merging the changes to the 4.3 branch, the deleted packages cannot be removed from the 4.3 repository.

No changelog was commited and no packages will be built in the oxse4ucs repository.
Comment 4 Daniel Tröder univentionstaff 2018-01-23 16:40:45 CET
Further commits in branch "dtroeder/46102_remove_cyrus" of repository ucs:

73a7e9cb: remove leftover
b74cffbb: modify deprecated example
adfe5ff8: remove deprecated cyrus related packaging code
83c0ad87: changelog
e4c0c09a: remove unused test code
Comment 5 Daniel Tröder univentionstaff 2018-01-24 12:54:02 CET
Packages have been build:

Branch: ucs_4.3-0
Scope: bleeding4.3

univention-l10n-fr 2.0.0-4A~4.3.0.201801240849
ucs-test 8.0.16-9A~4.3.0.201801240904
univention-mail-postfix 12.0.0-9A~4.3.0.201801240941
univention-spamassassin 9.0.0-2A~4.3.0.201801241004
univention-management-console-module-diagnostic 4.0.0-4A~4.3.0.201801241028
univention-directory-manager-modules 13.0.1-2A~4.3.0.201801241208
Comment 6 Daniel Tröder univentionstaff 2018-01-24 13:29:12 CET
All tests except 40_mail/47_mailForwardAddress succeeded in a KVM VM.
I will investigate 47_mailForwardAddress.


Starting 49 ucs-test at 2018-01-23 17:30:04 to /var/log/univention/test_1516725002.log
UCS 4.3-0-e0 ucs-test 8.0.16-9
=================================================== Section 'mail' ===================================================
Check if perfect forward secrecy (PFS) is enabled................................. Test passed
Basic email delivery.............................................................. Test passed
Basic group email delivery........................................................ Test passed
Basic email delivery to root...................................................... Test passed
Basic spam email delivery......................................................... Test passed
Basic virus email delivery........................................................ Test passed
Basic email functions............................................................. Test passed
IMAP mail login................................................................... Test passed
POP3 mail login................................................................... Test passed
Imap idle test.................................................................... Test passed
SPAM header tag test.............................................................. Test passed
Delivery to a mailing list........................................................ Test passed
Delivery to deactivated local account............................................. Test passed
Delivery to root without univention mail server................................... Test passed
Check authenticated delivery via port 25, 465 and 587............................. Test passed
Mail delivery via submission port................................................. Test passed
Test special mail adresses........................................................ Test passed
Mails to unknown users are rejected............................................... Test passed
Mails to ldap group............................................................... Test passed
Mail home server.................................................................. Test passed
Mail imap acl flags are correctly respected by the IMAP server.................... Test passed
Mail imap acl flags are correctly evaluated....................................... Test skipped (wrong version)
UCR configuration to disallow plain text passwords over non-TLS connections....... Test passed
check mail related modifications of user objects.................................. Test skipped (wrong version)
Imap Server with hunderds of connections.......................................... Test passed
sieve script...................................................................... Test passed
Test smart host configuration..................................................... Test skipped (wrong version)
Test update of mail/hosteddomains ucr variable.................................... Test passed
Test mail to nested groups........................................................ Test skipped (wrong version)
Test sender restrictions for mailing lists........................................ Test passed
Test sender restrictions for groups............................................... Test passed
Test mail/messagesizelimit........................................................ Test passed
Postfix accepts mails on port 25, 465 and 587..................................... Test passed
Test Dovecots mailquota support................................................... Test passed
Test Dovecots quota-status service for Postfix.................................... Test passed
Modification of user's mail primary address....................................... Test passed
Dovecot, test username modrdn while keeping mail primary address.................. Test passed
Add and remove mail primary address from shared folders........................... Test passed
Change primary mail address of shared folders..................................... Test passed
Create and remove shared folders with different settings of mail/dovecot/mailbox/d
elete............................................................................. Test passed
Create subfolder in shared folder and check permissions........................... Test passed
Test logon time with many groups in LDAP.......................................... Test passed
Dovecot, test behaviour if mail address is specified in mixed case................ Test passed
Dovecot, check permissions of spool directory..................................... Test passed
Test mailForwardAddress and mailForwardCopyToSelf................................. Test failed
Test UDM properties mailForwardAddress and mailForwardCopyToSelf.................. Test passed
Test postgrey can be stopped...................................................... Test skipped (missing software)
Check if main.cf.local is included................................................ Test passed
Fetchmail, check permissions of spool directory................................... Test skipped (missing software)
Comment 7 Philipp Hahn univentionstaff 2018-02-05 13:39:50 CET
Similar to Bug #45858 this also fixes the last issue of
$ find -name \*.maintscript -exec grep --color '_conffile\s\+[^/]' {} +
mail/univention-mail-cyrus/debian/univention-mail-cyrus.maintscript:rm_conffile etc/
Comment 8 Daniel Tröder univentionstaff 2018-02-13 11:09:01 CET
(In reply to Philipp Hahn from comment #7)
> Similar to Bug #45858 this also fixes the last issue of
> $ find -name \*.maintscript -exec grep --color '_conffile\s\+[^/]' {} +
> mail/univention-mail-cyrus/debian/univention-mail-cyrus.maintscript:
> rm_conffile etc/
Will be "fixed" by removing the entire univention-mail-cyrus package.
Comment 9 Daniel Tröder univentionstaff 2018-02-13 11:55:21 CET
[dtroeder/46102_remove_cyrus 7d7aa157b4] Bug #46102: abort if cyrus integration is installed
Comment 10 Daniel Tröder univentionstaff 2018-02-13 13:04:14 CET
Above commits were merged from branch dtroeder/46102_remove_cyrus to branch 4.3-0.

Source and binary packages for univention-mail-cyrus and univention-mail-cyrus-murder were removed from the UCS 4.3-0 repository.

Rebuild packages in UCS 4.3-0 scope:

univention-l10n-fr (2.0.0-4)
ucs-test (8.0.28-8)
univention-mail-postfix (12.0.0-12)
univention-spamassassin (9.0.0-2)
univention-management-console-module-diagnostic (4.0.0-11)
univention-directory-manager-modules (13.0.19-15)
univention-updater (13.0.1-14)

The source and binary package were removed from the ucs_4.3-0-bleeding4.3 scope.
Comment 11 Sönke Schwardt-Krummrich univentionstaff 2018-02-23 18:09:50 CET
base/univention-system-setup/usr/lib/univention-system-setup/scripts/10_basis/10hostname
base/univention-system-setup/usr/lib/univention-system-setup/scripts/10_basis/12domainname
base/univention-system-setup/usr/lib/univention-system-setup/scripts/40_ssl/10ssl
→ all 3 files contained cyrus specific code (e.g. SSL cert updates)
→ REOPEN: remove cyrus specific code

doc/errata/staging/univention-mail-postfix.yaml
→ REOPEN: remove advisory for #45422

mail/univention-mail-dovecot/modules/univention/mail/dovecot_shared_folder.py
→ contains UDM property "cyrus-userquota" that maps to "univentionMailUserQuota"
→ REOPEN: should we rename the UDM property? what sideeffects might this change trigger?

management/univention-directory-manager-modules/modules/univention/admin/handlers/mail/folder.py
→ contains UDM property "cyrus-userquota" that maps to "univentionMailUserQuota"
→ REOPEN: should we rename the UDM property? what sideeffects might this change trigger?

management/univention-ldap/control
→ contains extremely outdated references to "univention-mail-cyrus-quota-master"
→ REOPEN: can we remove the Replaces/Conflicts entries without endangering the current package dependencies? Or should we remove those entries later on?

Have a look at branch "sschwardt/46102/430/remove_cyrus"
Comment 12 Sönke Schwardt-Krummrich univentionstaff 2018-02-25 16:30:25 CET
(In reply to Daniel Tröder from comment #1)
> Please change the status of various Cyrus-related bugs to WONTFIX (e.g. Bug
> #37187).
→ marked as WONTFIX

(In reply to Daniel Tröder from comment #2)
> The 4.3 pre_up script will block updates if univention-mail-cyrus is found
> and display a link to an article: Bug #46112.
→ Test was ok:
Do you want to continue [Y/n]? 

Checking for space on /var/cache/apt/archives: OK
Checking for space on /boot: OK
Checking for space on /: OK
Checking for package status: OK
Checking LDAP schema: OK
ERROR: The Cyrus integration package was found. Cyrus is not
supported anymore by UCS 4.3. Aborting the upgrade. For instructions how to
proceed, please refer to https://help.univention.com/t/7957
Error: Please check "/var/log/univention/updater.log" for details.
ERROR: update failed. Please check /var/log/univention/updater.log

(In reply to Daniel Tröder from comment #3)
> Work in branch "dtroeder/46102_remove_cyrus" of repository ucs:
> 
> bb538ca3: remove univention-mail-cyrus
[...]
> 295b0569: remove support for Cyrus from ACL test
→ OK: code review

> Work in branch "4.3" of repository appsuite:
> 
> cf08b8dd: create 4.3 branch of OX integration
> 0de2ee3b: copyright
> 8c3ee874: remove univention-mail-cyrus-ox
→ OK
> 20d19d24: remove cyrus related code
→ side note: the old code checked if mail/dovecot/sieve/port is empty and set sievePort to 4190 only in this case. The new code sets the default sieve port if mail/dovecot is not set to true.
This is a change in behaviour, but I think the new version is better than the old one.

> Prior to merging the changes to the 4.3 branch, the deleted packages cannot
> be removed from the 4.3 repository.
→ the following packages do not exist below
  /var/univention/buildsystem2/mirror/testing/4.3/:
- univention-mail-cyrus
- univention-mail-cyrus-murder

(In reply to Daniel Tröder from comment #4)
> Further commits in branch "dtroeder/46102_remove_cyrus" of repository ucs:
> 
> 73a7e9cb: remove leftover
> b74cffbb: modify deprecated example
> adfe5ff8: remove deprecated cyrus related packaging code
> 83c0ad87: changelog
> e4c0c09a: remove unused test code
→ OK: code review


TODO:
- check if all packages are (re)built in 4.3-0
Comment 13 Daniel Tröder univentionstaff 2018-02-27 17:51:51 CET
(In reply to Sönke Schwardt-Krummrich from comment #11)
> base/univention-system-setup/usr/lib/univention-system-setup/scripts/
> 10_basis/10hostname
> base/univention-system-setup/usr/lib/univention-system-setup/scripts/
> 10_basis/12domainname
> base/univention-system-setup/usr/lib/univention-system-setup/scripts/40_ssl/
> 10ssl
> → all 3 files contained cyrus specific code (e.g. SSL cert updates)
> → REOPEN: remove cyrus specific code
>
> doc/errata/staging/univention-mail-postfix.yaml
> → REOPEN: remove advisory for #45422
→ Merged sschwardt/46102/430/remove_cyrus

> mail/univention-mail-dovecot/modules/univention/mail/dovecot_shared_folder.py
> → contains UDM property "cyrus-userquota" that maps to
> "univentionMailUserQuota"
> → REOPEN: should we rename the UDM property? what sideeffects might this
> change trigger?
UDM users/user property "UniventionDovecotUserQuota" was renamed to "mailUserQuota".

> management/univention-directory-manager-modules/modules/univention/admin/
> handlers/mail/folder.py
> → contains UDM property "cyrus-userquota" that maps to
> "univentionMailUserQuota"
> → REOPEN: should we rename the UDM property? what sideeffects might this
> change trigger?
UDM mail/folder property "cyrus-userquota" was renamed to "mailQuota".

> management/univention-ldap/control
> → contains extremely outdated references to
> "univention-mail-cyrus-quota-master"
> → REOPEN: can we remove the Replaces/Conflicts entries without endangering
> the current package dependencies? Or should we remove those entries later on?
I cannot imaging a scenario in which this could become a problem. Removed.

> Have a look at branch "sschwardt/46102/430/remove_cyrus"
Merged.


[4.3-0 ff6d3460a3] Bug #46102: rename UDM users/user property "UniventionDovecotUserQuota" to "mailUserQuota" and mail/folder "cyrus-userquota" to "mailQuota"
[4.3-0 7e58d81c6f] Bug #46102: use debian-systemd scripts
[4.3-0 812dd89e8e] Bug #46102: rename UDM mail/folder "cyrus-userquota" to "mailQuota"
[4.3-0 fac397bfaf] Bug #46102: remove deprecated package dependency
[4.3-0 a33d77e255] Bug #46102: changelog

[4.3-0 3ac9ed487c] Bug #46102: Merge branch 'sschwardt/46102/430/remove_cyrus' into 4.3-0

univention-mail-dovecot (4.0.0-7)
univention-directory-manager-modules (13.0.21-2)
univention-ldap (14.0.2-12)
univention-system-setup (11.0.2-6)
Comment 14 Daniel Tröder univentionstaff 2018-02-27 18:20:24 CET
[4.3-0 a69048f5b8] Bug #46102: adapt tests to renamed UDM property

ucs-test (8.0.28-53)
Comment 15 Daniel Tröder univentionstaff 2018-03-01 15:42:03 CET
I added a section to the UCS 4.3 changelog.

[4.3-0 fbdd57f83d] Bug #46102: changelog entry for Cyrus removal
[4.3-0 c89d7375fb] Bug #46102: changelog entry about UDM quota property renames
[4.3-0 34d8217122] Bug #46102: fix validity error

http://jenkins.knut.univention.de:8080/view/Doku/job/UCS-4.3/job/UCS-4.3-0/view/All/job/ReleaseNotes/lastSuccessfulBuild/artifact/webroot/release-notes-4.3-0-en.pdf
Comment 16 Daniel Tröder univentionstaff 2018-03-01 17:23:00 CET
[4.3-0 427e6edb25] Bug #46102: no need for restart in join script, require newer UDM, then no need to handle old property
Comment 17 Sönke Schwardt-Krummrich univentionstaff 2018-03-01 18:09:17 CET
(In reply to Daniel Tröder from comment #13)
> → Merged sschwardt/46102/430/remove_cyrus
→ OK

> UDM users/user property "UniventionDovecotUserQuota" was renamed to
> "mailUserQuota".
→ OK

> UDM mail/folder property "cyrus-userquota" was renamed to "mailQuota".
→ OK

> > management/univention-ldap/control
> > → contains extremely outdated references to
> > "univention-mail-cyrus-quota-master"
> > → REOPEN: can we remove the Replaces/Conflicts entries without endangering
> > the current package dependencies? Or should we remove those entries later on?
> I cannot imaging a scenario in which this could become a problem. Removed.
→ Me too. So I think the removal is ok.
→ OK

> > Have a look at branch "sschwardt/46102/430/remove_cyrus"
> Merged.
→ OK

> [4.3-0 ff6d3460a3] Bug #46102: rename UDM users/user property
> "UniventionDovecotUserQuota" to "mailUserQuota" and mail/folder
> "cyrus-userquota" to "mailQuota"
> [4.3-0 7e58d81c6f] Bug #46102: use debian-systemd scripts
> [4.3-0 812dd89e8e] Bug #46102: rename UDM mail/folder "cyrus-userquota" to
> "mailQuota"
> [4.3-0 fac397bfaf] Bug #46102: remove deprecated package dependency
> [4.3-0 a33d77e255] Bug #46102: changelog
> [4.3-0 3ac9ed487c] Bug #46102: Merge branch
> 'sschwardt/46102/430/remove_cyrus' into 4.3-0
→ OK

(In reply to Daniel Tröder from comment #14)
> [4.3-0 a69048f5b8] Bug #46102: adapt tests to renamed UDM property
→ OK

(In reply to Daniel Tröder from comment #15)
> I added a section to the UCS 4.3 changelog.
> 
> [4.3-0 fbdd57f83d] Bug #46102: changelog entry for Cyrus removal
> [4.3-0 c89d7375fb] Bug #46102: changelog entry about UDM quota property
> renames
> [4.3-0 34d8217122] Bug #46102: fix validity error
> 
> http://jenkins.knut.univention.de:8080/view/Doku/job/UCS-4.3/job/UCS-4.3-0/
> view/All/job/ReleaseNotes/lastSuccessfulBuild/artifact/webroot/release-notes-
> 4.3-0-en.pdf
→ OK

(In reply to Daniel Tröder from comment #16)
> [4.3-0 427e6edb25] Bug #46102: no need for restart in join script, require
> newer UDM, then no need to handle old property
→ OK

→ VERIFIED
Comment 18 Stefan Gohmann univentionstaff 2018-03-14 14:38:06 CET
UCS 4.3 has been released:
 https://docs.software-univention.de/release-notes-4.3-0-en.html
 https://docs.software-univention.de/release-notes-4.3-0-de.html

If this error occurs again, please use "Clone This Bug".
Comment 19 Philipp Hahn univentionstaff 2021-05-11 14:57:45 CEST
*** Bug 45466 has been marked as a duplicate of this bug. ***