Bug 46259 - Office 365 Connector for UCS 4.3
Office 365 Connector for UCS 4.3
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: Office 365
UCS 4.3
Other Linux
: P5 normal (vote)
: UCS 4.3
Assigned To: Daniel Tröder
Erik Damrose
: interim-3
Depends on: 45425 46493
Blocks:
  Show dependency treegraph
 
Reported: 2018-02-08 14:03 CET by Nico Gulden
Modified: 2018-03-14 14:38 CET (History)
4 users (show)

See Also:
What kind of report is it?: Release Management
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nico Gulden univentionstaff 2018-02-08 14:03:27 CET
The Office 365 Connector app should be available for UCS 4.3.
Comment 1 Daniel Tröder univentionstaff 2018-03-01 22:51:10 CET
Starting work on the app for UCS 4.3. Git repository was branched and the package version bumped:

[4.3 d9da1d6] Bug #46259: version bump for UCS 4.3, README txt2markdown

A new build scope was created and the package built:

Package: univention-office365
Version: 2.0.0-1A~4.3.0.201803012220
Branch: ucs_4.3-0
Scope: office365

A new app version was created for 4.2: "1.4" with updated integration package (1.0.1-11) and from that app version a new deb repository was branched for 4.3: "2.1". Both repositories' path is "office365_20180301223107".

python-jwt, python-cryptography (and dependencies) will not have to be rebuild, as they are in 4.3 now. With the version difference there could be API changes... we'll have to test this.

root@m60:~# apt-cache policy python-jwt
python-jwt:
  Installiert:           (keine)
  Installationskandidat: 1.4.2-1+deb9u1
  Versionstabelle:
     1.4.2-1+deb9u1 500
        500 http://updates-test.software-univention.de/4.3/maintained 4.3-0/all/ Packages

root@m60:~# apt-cache policy python-cryptography
python-cryptography:
  Installiert:           1.7.1-3
  Installationskandidat: 1.7.1-3
  Versionstabelle:
 *** 1.7.1-3 500
        500 http://updates-test.software-univention.de/4.3/maintained 4.3-0/amd64/ Packages

python-rsa is in unmaintained, so that it may have to be copied into the scope.

root@m60:~# apt-cache policy python-rsa
python-rsa:
  Installiert:           (keine)
  Installationskandidat: 3.4.2-1
  Versionstabelle:
     3.4.2-1 500
        500 http://updates-test.software-univention.de/4.3/unmaintained 4.3-0/all/ Packages

I will try to replace the two calls that are done with this library (rsa.PrivateKey.load_pkcs1() and rsa.sign()) with calls to python-cryptography, to get rid of the dependency.

No testing done yet.
Comment 2 Daniel Tröder univentionstaff 2018-03-05 15:11:16 CET
(In reply to Daniel Tröder from comment #1)
> I will try to replace the two calls that are done with this library
> (rsa.PrivateKey.load_pkcs1() and rsa.sign()) with calls to
> python-cryptography, to get rid of the dependency.
This turned out to be difficult, as the key that must be loaded is not what the file type suggests. There are multiple PKCS versions and proper detection is a mystery. So this will have to be done at another time.
Comment 3 Daniel Tröder univentionstaff 2018-03-05 15:25:57 CET
python-rsa was imported from 4.3-0 unmaintained into the app scope:

Package: python-rsa
Version: 3.4.2-1A~4.3.0.201803051524
Branch: ucs_4.3-0
Scope: office365
Comment 4 Daniel Tröder univentionstaff 2018-03-05 20:49:21 CET
* Version 2.0.0-2 of univention-office365 has been uploaded to the test appcenter.
* The README_UPDATE_EN and README_UPDATE_DE files have been filled with information about the update.
* The app can be installed on a UCS 4.3-0.
Comment 5 Daniel Tröder univentionstaff 2018-03-06 11:24:34 CET
[4.3 102a7f7] Bug #46259: adapt to changes on disabled/locked property in UCS 4.3

univention-office365 (2.0.0-3)

New version was uploaded to the test appcenter.
Comment 6 Erik Damrose univentionstaff 2018-03-06 12:23:02 CET
The last comment fixed an error when creating a new user. It wasnt synced to the azure AD.

reopen: bug #45729 was fixed for 4.2 but not yet QAed. The ldap filter for greup syncing was changed. Now i cannot sync any group, because the objectclass univentionOffice365 has to be present, previously only posixgroup had to be present.

OK: The wizard is now useable again thanks to updated screenshots and descriptions
Comment 7 Daniel Tröder univentionstaff 2018-03-06 12:30:52 CET
[4.3 4015720] Bug #46259: fix to restrictive group LDAP filter
univention-office365 (2.0.0-4)
uploaded to test appcenter
Comment 8 Erik Damrose univentionstaff 2018-03-06 14:04:19 CET
OK: App install on UCS 4.3
OK: User, group sync
OK: Single sign-on
verified
Comment 9 Erik Damrose univentionstaff 2018-03-06 14:06:11 CET
I published the app for 4.3
Comment 10 Stefan Gohmann univentionstaff 2018-03-14 14:38:40 CET
UCS 4.3 has been released:
 https://docs.software-univention.de/release-notes-4.3-0-en.html
 https://docs.software-univention.de/release-notes-4.3-0-de.html

If this error occurs again, please use "Clone This Bug".