Description Felix Botner 2018-02-13 11:58:47 CET

see, http://jenkins.knut.univention.de:8080/job/UCS-4.3/job/UCS-4.3-0/job/Update%20Tests/test_system=update-from-4.0-5-with-horde/ws/test/updater.log/*view*/

/tmp/tmpjd_Bwj']' returned non-zero exit status 126
2018-02-12 15:54:57,198 ERROR:univention.appcenter.actions.upgrade-search:Command '['docker', 'exec', '42dd285061a58ff6a30ddbd179614bc274e0c1514dd69f7bbbaace0e452a1153', u'/usr/share/univention-docker-container-mode/update_available', '--app', u'horde', '--app_version', u'5.2.7-3', '--error_file', u'/var/univention/tmp/tmpjd_Bwj']' returned non-zero exit status 126
Traceback (most recent call last):
  File "/usr/lib/pymodules/python2.7/univention/appcenter/actions/__init__.py", line 226, in call_with_namespace
    result = self.main(namespace)
  File "/usr/lib/pymodules/python2.7/univention/appcenter/actions/upgrade_search.py", line 60, in main
    upgrade_available = self._check_for_upgrades(app)
  File "/usr/lib/pymodules/python2.7/univention/appcenter/actions/docker_upgrade_search.py", line 50, in _check_for_upgrades
    output = self._execute_container_script(app, 'update_available', credentials=False, output=True)
  File "/usr/lib/pymodules/python2.7/univention/appcenter/actions/docker_base.py", line 154, in _execute_container_script
    return docker.execute_with_output(interface_file, *cmd_args, **cmd_kwargs)
  File "/usr/lib/pymodules/python2.7/univention/appcenter/docker.py", line 293, in execute_with_output
    return execute_with_output(self.container, args)
  File "/usr/lib/pymodules/python2.7/univention/appcenter/docker.py", line 146, in execute_with_output
    return check_output(args)
  File "/usr/lib/python2.7/subprocess.py", line 219, in check_output
    raise CalledProcessError(retcode, cmd, output=output)

Update_available (in the container) fails after the update to 4.3 (maybe dockerd has to be restarted).


(1)

We need to catch CalledProcessError in _check_for_upgrades. I want to logs to look like

INFO:univention.appcenter.actions.upgrade-search:Executing interface update_available for horde
ERROR:...:update_available failed (126): stdout/stderr

(2)

We need to think about how to proceed if _check_for_upgrades. 

(3)

The appcenter should not log into the updater.log, something like

Checking for app updates (see appcenter.log)    done

is enough

(4)

add a logrotate snippent for /var/log/univention/appcenter.log, e.g.

-> more management/univention-directory-manager-modules/conffiles/etc/logrotate.d/univention-directory-manager 
@%@UCRWARNING=# @%@

@!@
import univention.lib.ucrLogrotate

name = "sync-memberuid"
settings = univention.lib.ucrLogrotate.getLogrotateConfig(name, configRegistry)
print "/var/log/univention/%s.log {" % name
for setting in settings.keys():
	print "\t%s" % settings[setting]
print "}"