Bug 48717 - Log events to Admin Diary
Log events to Admin Diary
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: Admin Diary
UCS 4.4
Other Linux
: P5 normal (vote)
: UCS 4.4
Assigned To: Dirk Wiesenthal
Arvid Requate
: interim-3
Depends on: 48343 48738 48806
Blocks:
  Show dependency treegraph
 
Reported: 2019-02-20 16:03 CET by Dirk Wiesenthal
Modified: 2019-03-12 13:41 CET (History)
3 users (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments
dont_log_empty_mods.patch (1.18 KB, patch)
2019-03-04 22:59 CET, Arvid Requate
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Wiesenthal univentionstaff 2019-02-20 16:03:29 CET
1. Every UDM object creation
2. Every UDM object modification
3. Every UDM object move
4. Every UDM object removal
5. Join: Start and end
6. Failed join scripts
7. univention-upgrade: Start and end
8. Poweroff / Reboot
Comment 1 Philipp Hahn univentionstaff 2019-02-20 16:34:46 CET
(In reply to Dirk Wiesenthal from comment #0)
> 1. Every UDM object creation
> 2. Every UDM object modification

So we will log every cn=temporary object? "Great!"
Please have a look at file:/var/lib/univention-ldap/notify/transaction and please implement some sane filtering... at least some "triggered by direct user interaction" and not subsequently triggered by a chain of internal sub-actions.)

> 3. Every UDM object move
> 4. Every UDM object removal
> 5. Join: Start and end
> 6. Failed join scripts
> 7. univention-upgrade: Start and end
> 8. Poweroff / Reboot
Comment 2 Arvid Requate univentionstaff 2019-02-20 16:49:31 CET
> So we will log every cn=temporary object? "Great!"

No, we are not that stupid. Thanks for the feedback.
Comment 3 Dirk Wiesenthal univentionstaff 2019-02-25 16:10:08 CET
Implemented everything but

8. Poweroff / Reboot

I had problems with adding a script that runs before the system halts but rsync is still available for a as long as sending the data takes.
Comment 4 Dirk Wiesenthal univentionstaff 2019-02-26 14:22:33 CET
UDM_GENERIC_* and APP_UPGRADE_* and APP_REMOVE_* events in

univention-admin-diary 1.0.0-29A~4.4.0.201902261420
Comment 5 Arvid Requate univentionstaff 2019-03-04 22:59:49 CET
Created attachment 9884 [details]
dont_log_empty_mods.patch

As discussed, I would propose to avoid logging empty modifications, which occurr from the S4-Connector for every created user.
Comment 6 Dirk Wiesenthal univentionstaff 2019-03-04 23:46:02 CET
Done in
  univention-directory-manager-modules 14.0.9-2A~4.4.0.201903042337
Comment 7 Arvid Requate univentionstaff 2019-03-05 00:41:31 CET
Ok, works. The Admin Diary currently cannot correlate reflected S4-Connector changes, so they show up as unrelated changes by some cn=admin. To handle that in a better way would require changes far beyond the scope of the current project.

7e945274e9 | UCS 4.4 changelog entry
Comment 8 Florian Best univentionstaff 2019-03-12 13:41:01 CET
UCS 4.4 has been released:
 https://docs.software-univention.de/release-notes-4.4-0-en.html
 https://docs.software-univention.de/release-notes-4.4-0-de.html

If this error occurs again, please use "Clone This Bug".