Bug 48722 - no Domain Users $OU created when ucsschool/import/attach/policy/default-umc-users=no
no Domain Users $OU created when ucsschool/import/attach/policy/default-umc-u...
Status: CLOSED FIXED
Product: UCS@school
Classification: Unclassified
Component: General
UCS@school 4.4
Other Linux
: P5 normal (vote)
: UCS@school 4.4 v1
Assigned To: Ole Schwiegert
Daniel Tröder
:
Depends on:
Blocks: 48651
  Show dependency treegraph
 
Reported: 2019-02-21 08:00 CET by Daniel Tröder
Modified: 2019-03-12 10:59 CET (History)
2 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 5: Major Usability: Impairs usability in key scenarios
Who will be affected by this bug?: 2: Will only affect a few installed domains
How will those affected feel about the bug?: 3: A User would likely not purchase the product
User Pain: 0.171
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Tröder univentionstaff 2019-02-21 08:00:31 CET
When the UCRV ucsschool/import/attach/policy/default-umc-users is set to "false", the default-umc-users UMC policy should not be set on "Domain Users $OU".

Instead now the group "Domain Users $OU" isn't created.

* Fix create_ou behavior and clarify in UCRV description, that the default is "true".
* Check 90_ucsschool/110_set_default-umc-users.
* Check if the bug also exists in UCS@school 4.3.
Comment 1 Sönke Schwardt-Krummrich univentionstaff 2019-02-24 00:51:39 CET
--- a/ucs-school-lib/python/models/school.py
+++ b/ucs-school-lib/python/models/school.py
@@ -220,11 +220,11 @@ class School(RoleSupportMixin, UCSSchoolHelperAbstractClass):
 			group.create(lo)
 			group.add_umc_policy(self.get_umc_policy_dn('staff'), lo)
 
+		# cn=Domain Users %s
+		group = Group.cache("Domain Users %s" % (self.name,), self.name)
+		group.ucsschool_roles = [create_ucsschool_role_string(role_school_domain_group, self.name)]
+		group.create(lo)
 		if ucr.is_true('ucsschool/import/attach/policy/default-umc-users', True):
-			# cn=Domain Users %s
-			group = Group.cache("Domain Users %s" % (self.name,), self.name)
-			group.ucsschool_roles = [create_ucsschool_role_string(role_school_domain_group, self.name)]
-			group.create(lo)
 			group.add_umc_policy("cn=default-umc-users,cn=UMC,cn=policies,%s" % (ucr.get('ldap/base'),), lo)
 
 	def get_dc_name_fallback(self, administrative=False):
Comment 2 Ole Schwiegert univentionstaff 2019-02-25 12:34:26 CET
Package: ucs-school-lib
Version: 12.1.0-12A~4.4.0.201902251228
Branch: ucs_4.4-0
Scope: ucs-school-4.4

Package: ucs-school-import
Version: 17.0.4-9A~4.4.0.201902251230
Branch: ucs_4.4-0
Scope: ucs-school-4.4

Package: ucs-test-ucsschool
Version: 6.0.0-24A~4.4.0.201902251233
Branch: ucs_4.4-0
Scope: ucs-school-4.4

Group is now created and test passes on local VM
Comment 3 Ole Schwiegert univentionstaff 2019-02-25 12:54:24 CET
Package: ucs-school-lib
Version: 11.0.2-5A~4.3.0.201902251246
Branch: ucs_4.3-0
Scope: ucs-school-4.3

Package: ucs-school-import
Version: 16.0.3-3A~4.3.0.201902251248
Branch: ucs_4.3-0
Scope: ucs-school-4.3

Package: ucs-test-ucsschool
Version: 5.0.4-5A~4.3.0.201902251251
Branch: ucs_4.3-0
Scope: ucs-school-4.3
Comment 4 Daniel Tröder univentionstaff 2019-02-25 12:56:21 CET
OK: fix test 110_..
OK: manual test: when UCR is set to true, Domain Users $OU is created, but the policy isn't attached
OK: advisories
Comment 5 Sönke Schwardt-Krummrich univentionstaff 2019-03-12 10:59:11 CET
UCS@school 4.4 v1 has been released.

https://docs.software-univention.de/release-notes-ucsschool-4.4v1-de.html

If this error occurs again, please clone this bug.