Univention Bugzilla – Bug 48730
call_joinscript calls joinscripts even if system is unjoined (if used e.g. in .postinst)
Last modified: 2021-05-25 16:02:14 CEST
call_joinscript of base.sh of shell-univention-lib always calls the specified joinscript on DC master and DC backup systems even if e.g. the DC backup system has not even joined yet. This causes some unneccessary errors and delays if software is installed before first join (→ e.g. via UCS@school join hook).
Idea: call_joinscript does not call any joinscript if /var/univention-join/status does not exist or its size is 0 bytes. univention-join truncates the status file after the computer account has been created and before any "join/pre-joinscripts" hook is called.
I stumbled over this mis-behaviour while working on Bug #52211. (In reply to Sönke Schwardt-Krummrich from comment #1) > Idea: > call_joinscript does not call any joinscript if /var/univention-join/status ... size is 0 bytes. That would prevent calling ANY script as the file is empty on start. call_joinscript now checks that "/var/univention-join/status" exists: [5.0-0] 967f0c84dd Bug #48730 join: Only call join scripts on joined system doc/changelog/changelog-5.0-0.xml | 3 +++ management/univention-join/debian/changelog | 1 + management/univention-join/join.sh | 2 ++ 3 files changed, 6 insertions(+) Package: univention-join Version: 12.0.0-7A~5.0.0.202010151156 Branch: ucs_5.0-0
Seems legit. I could not find any trouble. This most likely won't fix the use case from comment 1 but the behavior is better than before. The silent exit code 0 hopefully won't make any trouble. OK: changelog entry
UCS 5.0 has been released: https://docs.software-univention.de/release-notes-5.0-0-en.html https://docs.software-univention.de/release-notes-5.0-0-de.html If this error occurs again, please use "Clone This Bug".