Bug 52211 - Introduce DebHelper sequence for univention-join
Introduce DebHelper sequence for univention-join
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: Join (univention-join)
UCS 5.0
Other Linux
: P5 normal (vote)
: UCS 5.0
Assigned To: Philipp Hahn
Florian Best
:
Depends on:
Blocks: 53209
  Show dependency treegraph
 
Reported: 2020-10-13 13:12 CEST by Philipp Hahn
Modified: 2021-05-25 16:01 CEST (History)
0 users

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Hahn univentionstaff 2020-10-13 13:12:08 CEST
*.inst and *.uinst scripts are currently added manually in many places in debian/*.

Similar to Bug #51656 for l10n, Bug #51949 for UCR and Bug #51950 for UMC we should provide a sequence "univention-join" to
- automatically install the files in the right location
- add the required #DEBHELPER# fragments
Comment 1 Philipp Hahn univentionstaff 2020-10-15 13:29:57 CEST
1. The shell library for join has been moved from base/univention-lib/ to management/univention-join/
1.1 Several shell issues has been fixed in base.sh
1.2 join.sh has been refactored to remove code duplication
1.3 Also fixed Bug #48730 while doing that

2. The old implementation has been moved from packaging/univention-debhelper/ to management/univention-join/
2.1 The old package univention-debhelper is now (currently) a transitional package to univention-join-dev as is is now empty except the backward compatibility symbolic link.
2.2 The 4 packages using that old implementation have been changed to use the new debhelper sequence

3. ucslint has been extended to check for the old mechanism
3.1 the old transitional dummy package "ucslint-univention" has been removed

4. The developer documentation has been updated

[5.0-0] 4a50d21e54 Bug #52211: univention-join debhelper sequence
[5.0-0] 478d3753e3 Bug #52211 dh: Migrate to univention-join-dev
 management/univention-appcenter/debian/changelog                  | 6 ++++++
 management/univention-appcenter/debian/control                    | 2 +-
 management/univention-appcenter/debian/rules                      | 3 +--
 management/univention-portal/debian/changelog                     | 6 ++++++
 management/univention-portal/debian/control                       | 2 +-
 management/univention-portal/debian/rules                         | 6 +-----
 packaging/univention-debhelper/debian/changelog                   | 6 ++++++
 packaging/univention-debhelper/debian/control                     | 8 ++------
 .../univention-debhelper/debian/univention-debhelper.install      | 1 -
 packaging/univention-debhelper/debian/univention-debhelper.links  | 1 +
 ...
 18 files changed, 41 insertions(+), 177 deletions(-)

[5.0-0] 8b269509fa Bug #52211 ucslint: Remove transitional dummy package
 packaging/ucslint/debian/control | 18 ------------------
 1 file changed, 18 deletions(-)

[5.0-0] 08ed24bd0a Bug #52211 ucslint: Test for univention-join dh sequence
 packaging/ucslint/debian/changelog                 |  6 +++++
 packaging/ucslint/testframework/0001-22.correct    |  1 +
 packaging/ucslint/testframework/0001-22/00bin.inst |  7 ++++++
 .../ucslint/testframework/0001-22/debian/changelog |  5 ++++
 .../ucslint/testframework/0001-22/debian/compat    |  1 +
 .../ucslint/testframework/0001-22/debian/control   | 13 ++++++++++
 .../ucslint/testframework/0001-22/debian/copyright | 29 ++++++++++++++++++++++
 .../ucslint/testframework/0001-22/debian/rules     |  3 +++
 packaging/ucslint/testframework/0001-23.correct    |  1 +
 packaging/ucslint/testframework/0001-23/00bin.inst |  7 ++++++
 ...
 18 files changed, 225 insertions(+), 83 deletions(-)

[5.0-0] 0552151447 Bug #52211 join: Update developer documentation
 .../join/join-template/debian/compat               |  2 +-
 .../join/join-template/debian/control              |  4 +-
 .../join-template/debian/join-template.install     |  2 -
 .../join-template/debian/join-template.postinst    | 14 ----
 .../join/join-template/debian/join-template.postrm | 11 ----
 .../join/join-template/debian/join-template.prerm  | 11 ----
 .../join/join-template/debian/rules                |  2 +
 doc/developer-reference/join/join.xml              | 74 +++++++---------------
 .../udm/ea/debian/extended-attribute.postinst      |  9 ---
 doc/developer-reference/udm/udm.xml                |  4 --
 10 files changed, 28 insertions(+), 105 deletions(-)

[5.0-0] 41cebbb579 Bug #52211 join: Add debhelper sequence for join
 doc/changelog/changelog-5.0-0.xml                  |   5 +
 management/univention-join/debian/changelog        |   1 +
 management/univention-join/debian/control          |  24 ++-
 .../debian/univention-join-dev.install             |   2 +
 .../univention-join/dh-univention-join-install     | 200 +++++++++++++++++++++
 management/univention-join/univention_join.pm      |  35 ++++
 .../univention-debhelper/univention/debhelper.py   |  36 +++-
 7 files changed, 298 insertions(+), 5 deletions(-)

[5.0-0] f14033cf47 Bug #52211 lib: More shellcheck cleanup
 base/univention-lib/shell/base.sh | 65 ++++++++++++++++-----------------------
 1 file changed, 27 insertions(+), 38 deletions(-)

[5.0-0] fce82c16e0 Bug #52211 join: Move join function to separate lib
 base/univention-lib/debian/changelog               |   6 ++
 base/univention-lib/debian/control                 |   2 +
 base/univention-lib/shell/base.sh                  | 100 +----------------
 management/univention-join/debian/changelog        |   6 ++
 .../univention-join/debian/univention-join.install |  17 +--
 management/univention-join/join.sh                 | 119 +++++++++++++++++++++
 6 files changed, 145 insertions(+), 105 deletions(-)

[5.0-0] 939ab3de16 Bug #52211 ucslint: Remove transitional dummy package
 packaging/ucslint/debian/ucslint.install | 1 -
 1 file changed, 1 deletion(-)


Package: univention-lib
Version: 9.0.9-2A~5.0.0.202010151123

Package: univention-debhelper
Version: 2.0.0-3A~5.0.0.202010151132

Package: univention-join
Version: 12.0.0-7A~5.0.0.202010151156

Package: ucslint
Version: 9.0.0-2A~5.0.0.202010151150
Version: 9.0.0-2A~5.0.0.202010151317


Affected downstream packages:

Package: univention-admin-diary
Version: 2.0.1-2A~5.0.0.202010151302

Package: univention-postgresql
Version: 12.0.1-1A~5.0.0.202010151307

Package: univention-appcenter
Version: 9.0.1-3A~5.0.0.202010151313

Package: univention-portal
Version: 4.0.1-10A~5.0.0.202010151321



Follow up:
- change all other packages over to univention-join-dev - see <https://git.knut.univention.de/univention/ucs/-/tree/fbest/univention-join-debhelper> commit named "Use univention-join sequence for DebHelper".
- review carefully for change in behavior by moving the call to #DEBHELPER# in relation to setting UCRV and doing other stuff in debian/$pkg.postinst
Comment 2 Philipp Hahn univentionstaff 2020-10-15 16:28:50 CEST
[5.0-0] 2803ef9129 Bug #52211 ucslint: Fix univention-join dh sequence test
 packaging/ucslint/debian/changelog                           | 2 +-
 packaging/ucslint/univention/ucslint/0001-CheckJoinScript.py | 7 ++++---
 2 files changed, 5 insertions(+), 4 deletions(-)

[5.0-0] 6d51aa753e Bug #52211 umc: Fix duplicate join script registration
 .../univention-management-console/debian/changelog |  6 ++++
 .../univention-management-console/debian/control   |  1 +
 .../dev/dh-umc-module-install                      | 33 +++++++++-------------
 .../univention-management-console/dev/umc.pm       |  2 ++
 4 files changed, 22 insertions(+), 20 deletions(-)

Package: ucslint
Version: 9.0.0-3A~5.0.0.202010151512

Package: univention-management-console
Version: 12.0.2-4A~5.0.0.202010151627
Comment 3 Florian Best univentionstaff 2020-10-15 17:39:36 CEST
OK: dh-univention-join-install

OK: ucslint 0001-22
OK: ucslint 0001-23
OK: ucslint-univention

OK: univention-appcenter
OK: univention-admin-diary
OK: univention-postgresql
OK: univention-portal

OK: docs
OK: changelog entry
Comment 4 Philipp Hahn univentionstaff 2021-04-21 13:06:02 CEST
[5.0-0] 65dcebc7ca fix[lib]: Force univention-join upgrade
 base/univention-lib/debian/changelog | 6 ++++++
 base/univention-lib/debian/control   | 2 ++
 2 files changed, 8 insertions(+)

Package: univention-lib
Version: 9.0.11-3A~5.0.0.202104211228
Comment 5 Florian Best univentionstaff 2021-05-25 16:01:09 CEST
UCS 5.0 has been released:
 https://docs.software-univention.de/release-notes-5.0-0-en.html
 https://docs.software-univention.de/release-notes-5.0-0-de.html

If this error occurs again, please use "Clone This Bug".