Bug 49029 – Error message for failed authentication is always english

Bug 49029 - Error message for failed authentication is always english


Summary:	Error message for failed authentication is always english

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	UMC (Generic)
Version:	UCS 4.3
Hardware:	Other All

Importance:	P5 normal (vote)
Target Milestone:	UCS 4.4-0-errata
Assigned To:	Florian Best
QA Contact:	Arvid Requate

URL:
Keywords:

Duplicates:	44737 (view as bug list)
Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2019-03-18 15:39 CET by Michael Grandjean
Modified:	2019-07-15 13:51 CEST (History)
CC List:	2 users (show)

See Also:
What kind of report is it?:	Bug Report
What type of bug is this?:	4: Minor Usability: Impairs usability in secondary scenarios
Who will be affected by this bug?:	5: Will affect all installed domains
How will those affected feel about the bug?:	2: A Pain – users won’t like this once they notice it
User Pain:	0.229
Enterprise Customer affected?:
School Customer affected?:	Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Flags:	best: Patch_Available+

Attachments
Screenshot: German UMC login with english error message (34.40 KB, image/png) 2019-03-18 15:39 CET, Michael Grandjean	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michael Grandjean

2019-03-18 15:39:57 CET

Created attachment 9932 [details]
Screenshot: German UMC login with english error message

root@ucs01:~# univention-app info
UCS: 4.3-3 errata456
Installed: ucsschool=4.3 v6
Upgradable: ucsschool

Scenario: Login at UMC, language is german. The entered credentials are wrong (username or password). The error message is always in english:
"The authentication has failed, please login again."

The error message should be localized, too.

Comment 2 Florian Best

2019-03-18 16:10:53 CET

Is it the SAML login or the default login?

Comment 3 Florian Best

2019-03-18 16:18:46 CET

(In reply to Florian Best from comment #2)
> Is it the SAML login or the default login?

It's the non SAML login.

Comment 4 Florian Best

2019-03-18 16:53:18 CET

Here is a patch:

diff --git a/management/univention-management-console/src/univention/management/console/protocol/session.py b/management/univention-management-console/src/univention/management/console/protocol/session.py
index 71bdc97d6e..4e939e4aff 100644
--- a/management/univention-management-console/src/univention/management/console/protocol/session.py
+++ b/management/univention-management-console/src/univention/management/console/protocol/session.py
@@ -977,6 +977,7 @@ def handle(self, request):
 »   »   »   from univention.management.console.protocol.server import Server
 »   »   »   Server.reload()
 »   »   »   try:
+»   »   »   »   request.body['locale'] = str(self.i18n.locale)
 »   »   »   »   self.__auth.authenticate(request)
 »   »   »   except (TypeError, KeyError):
 »   »   »   »   response = Response(request)

Comment 5 Michael Grandjean

2019-04-11 16:44:26 CEST

Just as an addition: The message that appears if a password change is required is also always in english.

Comment 6 Florian Best

2019-04-11 17:14:24 CEST

Okay, I applied the hotfix because it works :-D I am not really happy with the solution but maybe it can be improoved on another bug squashing day.

univention-management-console.yaml
d47a9952e93e | YAML Bug #49029

univention-management-console (11.0.4-11)
42788197f065 | Bug #49029: fix translation of authentication messages

Comment 7 Florian Best

2019-04-11 17:14:59 CEST

I hope the ucs-test are not using an german connection ! :-P

Comment 8 Arvid Requate

2019-04-11 19:10:44 CEST

* Functional test: Ok
* Advisory: Ok

Comment 9 Florian Best

2019-04-12 11:46:23 CEST

I fixed the language of the broken test cases:

ucs-test (9.0.2-31)
6c1f66938bfc | Bug #49029: set english language in test cases

Comment 10 Arvid Requate

2019-05-02 13:22:15 CEST

<http://errata.software-univention.de/ucs/4.4/70.html>

Comment 11 Florian Best

2019-07-15 13:51:25 CEST

*** Bug 44737 has been marked as a duplicate of this bug. ***