Bug 49305 - Sign logout responses in the IDP configuration
Sign logout responses in the IDP configuration
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: SAML
UCS 4.4
Other Linux
: P5 normal (vote)
: UCS 4.4-3-errata
Assigned To: Julia Bremer
Johannes Keiser
:
: 50603 (view as bug list)
Depends on:
Blocks: 51041
  Show dependency treegraph
 
Reported: 2019-04-17 09:15 CEST by Florian Best
Modified: 2020-03-30 12:50 CEST (History)
8 users (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?: Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:
best: Patch_Available+


Attachments
patch (888 bytes, patch)
2019-04-17 09:17 CEST, Florian Best
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Best univentionstaff 2019-04-17 09:15:30 CEST
Missing in the configuration for the service providers is:

        'sign.logout' => true,

Without signed logout responses the OX appsuite crashes during logout with an internal server error.

We also do not explicitly set the following attributes:
       'saml20.sign.response' => true,
       'saml20.sign.assertion' => true,

I guess they are by default true?! Otherwise we should set them, too.

This can simply be set, we don't need to make it configurable in the UMC/UDM.
Comment 1 Florian Best univentionstaff 2019-04-17 09:17:35 CEST
Created attachment 9975 [details]
patch
Comment 2 Florian Best univentionstaff 2019-04-17 09:27:08 CEST
       'saml20.sign.response' => true,
       'saml20.sign.assertion' => true,
→ Yes they are by default true.

We can also set the "sign.logout" at the IDP configuration. The SP configurations are inheriting the value!
https://simplesamlphp.org/docs/stable/simplesamlphp-reference-sp-remote
https://simplesamlphp.org/docs/stable/simplesamlphp-reference-idp-remote
Comment 3 Michael Grandjean univentionstaff 2019-12-19 13:42:06 CET
*** Bug 50603 has been marked as a duplicate of this bug. ***
Comment 4 Michael Grandjean univentionstaff 2019-12-19 13:43:27 CET
Bug #50603 is a duplicate, but public and with values for User Pain.
Comment 5 Florian Best univentionstaff 2019-12-19 13:44:50 CET
Required for the OX app. Otherwise logout fails.
Comment 6 Ingo Steuwer univentionstaff 2020-01-28 06:36:35 CET
see also patch attached to #50603
https://forge.univention.org/bugzilla/attachment.cgi?id=10254
Comment 7 Christian Castens univentionstaff 2020-02-07 10:11:34 CET
8c259f63cc Bug #49305: fix signed logout

Package: univention-saml
Version: 6.0.2-21A~4.4.0.202002070958
Branch: ucs_4.4-0
Scope: errata4.4-3

patch from bug #50603 applied to enable signed logouts
Comment 8 Erik Damrose univentionstaff 2020-02-07 17:16:29 CET
Some general remarks: Please set yourself as bug assignee when fixing a bug, and set the correct target milestone. If you think the bug is ready for QA, set the bug status to resolved.

OK: Patch was applied.

Reopen: The fix does not fulfill the userstory acceptance criteria
https://taiga.knut.univention.de/project/oschwieg-ucs-core/us/743

* There is no option to toggle signed logouts for a serviceprovider
* No resync of listener module to rewrite existing configurations
Comment 9 Julia Bremer univentionstaff 2020-02-10 18:15:55 CET
887b0ad0ec Bug #49305: yaml
fdb54868eb Bug #49305: translations
b6256ffdcc Bug #49305: Merge branch 'jbremer/bug49305' into 4.4-3
977961432c Bug #49305: Enable signed Logout, new udm attribute signLogouts

Successful build
Package: univention-saml
Version: 6.0.2-23A~4.4.0.202002101801
Branch: ucs_4.4-0
Scope: errata4.4-3
User: jbremer


I add the udm attribute signLogouts for serviceproviders, which is mapped to the new ldap attribute signLogouts. 
Its value determines whether to sign logout messages sent to this SP. Its default value is "True".
Comment 10 Johannes Keiser univentionstaff 2020-02-11 10:00:58 CET
OK new UDM attribute for "Enable signed logouts"
OK "sign.logout" is written into the service provider config file if UDM attribute is enabled
OK yaml
-> verified
Comment 11 Erik Damrose univentionstaff 2020-02-12 15:40:30 CET
<http://errata.software-univention.de/ucs/4.4/443.html>