Bug 50416 - Fix modifying the school_class attribute in ID Sync app
Summary: Fix modifying the school_class attribute in ID Sync app
Status: VERIFIED FIXED
Alias: None
Product: UCS@school
Classification: Unclassified
Component: ucsschool-id-connector
Version: UCS@school 4.4
Hardware: Other Linux
: P5 normal
Target Milestone: ---
Assignee: Daniel Tröder
QA Contact: Ole Schwiegert
URL:
Keywords:
Depends on:
Blocks: 50689
  Show dependency treegraph
 
Reported: 2019-10-25 17:35 CEST by Daniel Tröder
Modified: 2020-01-07 11:30 CET (History)
1 user (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Customer ID:
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Tröder univentionstaff 2019-10-25 17:35:26 CEST

    
Comment 2 Daniel Tröder univentionstaff 2019-10-28 15:13:54 CET
When changing school classes, groups and not users are modified.
Handling of groups/group objects was added in a way, that when school classes are changed, all current and former members are rescheduled.

This fixed both the class_change and the school_change integration tests.

[master] 5a49791 Bug #50416: move user (re)scheduling code
[master] 8a9cd0d Bug #50416: fix creation of 'school_classes' attribute
[master] fd47c2d Bug #50416: make decision of which school_authorities to distribute to a plugin
[master] ff313ec Bug #50416: PS 'fix creation of school_classes attribute'
[master] 0dfebe8 Bug #50416: handle listener files for users and groups
[master] 7bf1835 Bug #50416: fixes
[master] f07a36e Bug #50416: fix class change and school change tests
[master] 03abf04 Bug #50416: acquire logger at runtime
[master] 87f1c96 Bug #50416: patch logger using pytest.mark.usefixtures and fastapi dependency_overrides
[master] 627ee7a Bug #50416: check for correct type
Comment 3 Ole Schwiegert univentionstaff 2019-10-29 09:53:40 CET
What was tested:
Code Review: discussion about school class identification currently blocks the verification
Tests (Unit+Integration): OK
manual testing: OK
Comment 4 Ole Schwiegert univentionstaff 2019-10-29 11:16:09 CET
Code stays it is and will be redesigned with the switch to the official kelvin API