Bug 51747 - login.{definition,translation}.json is missing dependency on used UCR variable
Summary: login.{definition,translation}.json is missing dependency on used UCR variable
Status: CLOSED FIXED
Alias: None
Product: UCS
Classification: Unclassified
Component: SAML
Version: UCS 4.4
Hardware: Other Linux
: P5 normal
Target Milestone: UCS 4.4-5-errata
Assignee: Johannes Keiser
QA Contact: Jürn Brodersen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-30 11:52 CEST by Johannes Keiser
Modified: 2020-08-05 15:15 CEST (History)
0 users

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 3: Simply Wrong: The implementation doesn't match the docu
Who will be affected by this bug?: 1: Will affect a very few installed domains
How will those affected feel about the bug?: 1: Nuisance – not a big deal but noticeable
User Pain: 0.017
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Regression
Customer ID:
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Johannes Keiser univentionstaff 2020-07-30 11:52:30 CEST 
E:0004-12: conffiles/etc/simplesamlphp/univentiontheme/dictionaries/login.translation.json: template file contains variables that are not registered in file entry:
	- domainname
E:0004-12: conffiles/etc/simplesamlphp/univentiontheme/dictionaries/login.definition.json: template file contains variables that are not registered in file entry:
	- domainname
Comment 1 Johannes Keiser univentionstaff 2020-07-30 12:06:02 CEST 
ff28d9a49e Bug #51718: yaml  // wrong bugnumber was a mistake
d6af166435 Bug #51747: yaml
de1b32a51e Bug #51747: debian changelog
4fdaeb2114 Bug #51747: add missing ucr var dependency

Successful build
Package: univention-saml
Version: 6.0.2-47A~4.4.0.202007301158
Branch: ucs_4.4-0
Scope: errata4.4-5
Comment 2 Jürn Brodersen univentionstaff 2020-07-30 12:38:37 CEST 
What I tested:
login.definition.json and login.translation.json are registered to "domainname" -> OK
YAML -> OK

Possible impact:
If a backup is updated before it has been joined it would not show the domainname in the saml login page title (I don't see any other scenario). The json itself just contains an empty string and is still valid.
It can be fixed with "ucr commit" and will be fixed with this update.