Bug 51765 - Set a default value for backup/clean/max_age
Summary: Set a default value for backup/clean/max_age
Status: CLOSED FIXED
Alias: None
Product: UCS
Classification: Unclassified
Component: General
Version: UCS 4.4
Hardware: Other Linux
: P5 normal
Target Milestone: UCS 4.4-6-errata
Assignee: Jan Luttermann
QA Contact: Felix Botner
URL: https://git.knut.univention.de/univen...
Keywords:
Depends on:
Blocks: 52340
  Show dependency treegraph
 
Reported: 2020-08-03 16:10 CEST by Christian Völker
Modified: 2024-09-03 11:54 CEST (History)
7 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 2: Improvement: Would be a product improvement
Who will be affected by this bug?: 3: Will affect average number of installed domains
How will those affected feel about the bug?: 2: A Pain – users won’t like this once they notice it
User Pain: 0.069
Enterprise Customer affected?:
School Customer affected?: Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number: 2020080321000439, 2020080621000621, 2020092321000104
Bug group (optional):
Customer ID:
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Völker univentionstaff 2020-08-03 16:10:36 CEST
Frequently customers notice strange behaviour which is caused by no more disk space available.

Besides of logfiles customers are usually NOT aware of our build-in backup procedure and therefore loads of unneeded backup data is located at /var/univention-backup.

I never experienced a customer wanting to roll back a full year or more!

Customers not monitoring the free space will likely fail at some stage as replication will suddenly fail and other errors. They call support then.

In order to prevent the outdated backups to fill up disk space we should *by default* limit the backup files to 365 days.

So the variable should be set even on all already installed hosts (when not set otherwise).

backup/clean/max_age=365
Comment 1 Bernhard M. Wiedemann 2020-10-19 11:36:49 CEST
We hit this problem now on our SUSE/openSUSE deployment after 5-6 months of operation filling 40GB.

Here is a simple patch:

--- /usr/share/univention-lib/backup.sh.orig    2020-07-07 17:00:15.000000000 +0200
+++ /usr/share/univention-lib/backup.sh 2020-10-19 11:33:32.967810718 +0200
@@ -44,5 +44,5 @@
        local backup_dir="/var/univention-backup"
        local pattern="$backup_dir/$arg_pattern"
-       local max_age="${arg_max_age:-$backup_clean_max_age}"
+       local max_age="${arg_max_age:-${backup_clean_max_age:-365}}"
 
        if [ -n "$max_age" ]; then
Comment 3 Jan Luttermann univentionstaff 2020-11-04 15:25:12 CET
univention-lib
univention-ldap
(Bug #51765: setting max_age ucr variable)
Comment 4 Felix Botner univentionstaff 2020-11-06 10:09:04 CET
FAIL - yaml

univention-lib.yaml - maybe something like
 "Evaluation of ucr vaiables in the function clean_old_backups has been fixed

univention-ldap.yaml - please specify the name of the ucr varibale (backup/clean/max/age)

FAIL - Merge Request

increase the version in debian/changelog for univention-lib
and why are lines removed from both debian/changelog files?


OK - backup/clean/max/age is 365 for new installations
OK - no default for updates
Comment 5 Felix Botner univentionstaff 2020-11-06 10:32:05 CET
OK - MR
OK - yaml
Comment 6 Felix Botner univentionstaff 2020-11-10 11:58:02 CET
The name of the variable is

  backup/clean/max_age

not backup/clean/max/age
Comment 7 Florian Best univentionstaff 2020-11-10 19:55:50 CET
git:0513967b425030b89b16b43ff581931eed988f60 changed two packages without changing debian/changelog.
Comment 8 Jan Luttermann univentionstaff 2020-11-11 10:43:08 CET
changed ucr variable name max_age and updated debian/changelog
Comment 9 Felix Botner univentionstaff 2020-11-12 08:51:58 CET
please also update the MR (https://git.knut.univention.de/univention/ucs/-/merge_requests/25/)
Comment 10 Jan Luttermann univentionstaff 2020-11-16 09:55:22 CET
Bug Fixed in MR https://git.knut.univention.de/univention/ucs/-/merge_requests/31
Comment 11 Felix Botner univentionstaff 2020-11-16 10:13:36 CET
OK
Comment 13 Arvid Requate univentionstaff 2020-11-18 17:07:56 CET
FYI: Typo in advisory: "ucr vaiables"