Bug 56736 - clean_old_backups ignores backup/clean/min_backups
Summary: clean_old_backups ignores backup/clean/min_backups
Status: CLOSED FIXED
Alias: None
Product: UCS
Classification: Unclassified
Component: univention-lib
Version: UCS 5.0
Hardware: Other Linux
: P5 normal
Target Milestone: UCS 5.0-8-errata
Assignee: Arvid Requate
QA Contact: UCS maintainers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-17 10:48 CEST by Finn David
Modified: 2024-09-04 17:51 CEST (History)
2 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 3: Simply Wrong: The implementation doesn't match the docu
Who will be affected by this bug?: 5: Will affect all installed domains
How will those affected feel about the bug?: 2: A Pain – users won’t like this once they notice it
User Pain: 0.171
Enterprise Customer affected?: Yes
School Customer affected?: Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number: 2023101721000037, 2024090221000217
Bug group (optional):
Customer ID: 00009
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Finn David univentionstaff 2023-10-17 10:48:28 CEST 
The function clean_old_backups in /usr/share/univention-lib/backup.sh ignores the ucr variable backup/clean/min_backups because of a typo in line 45:

eval "$(univention-config-registry shell backup/clean/min/backups backup/clean/max_age)"

min/backups should read min_backups


The customer pointed out the mistake and provided a solution/patch in the ticket.
Comment 1 Finn David univentionstaff 2024-09-02 15:39:29 CEST 
Another customer is affected and runs into trouble with disk space because of this bug.
Comment 3 Arvid Requate univentionstaff 2024-09-03 12:55:39 CEST 
1a1dfc14a4 | Fix typo n UCR backup/clean/min_backups

Package: univention-lib
Version: 9.0.19-2
Branch: 5.0-0
Scope: errata5.0-8
Comment 4 Arvid Requate univentionstaff 2024-09-03 13:05:34 CEST 
Lean bug verification:
* Fix and merge via feature branch
* Successful installation of new package from apt
* Advisory Ok

This update addresses the following issues:
* A typo in evaluation of the UCR variable `backup/clean/min_backups`
  caused that the specified limit was not considered but instead the
  default value of `10` was applied. This has been fixed.
Comment 5 Arvid Requate univentionstaff 2024-09-04 10:45:30 CEST 
f9601ed34e | cherry-pick to 5.2-0

Package: univention-lib
Version: 11.0.8
Branch: 5.2-0