Bug 52241 - Failing mail tests under UCS 5
Failing mail tests under UCS 5
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: Mail
UCS 5.0
Other Linux
: P5 normal (vote)
: UCS 5.0
Assigned To: Jan Luttermann
Sönke Schwardt-Krummrich
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2020-10-20 16:41 CEST by Sönke Schwardt-Krummrich
Modified: 2021-05-25 16:03 CEST (History)
1 user (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sönke Schwardt-Krummrich univentionstaff 2020-10-20 16:41:52 CEST
There are several mail tests that are failing under UCS 5:

00check_forward_secrecy
24_mailHomeServer
25_imap_acls_correctly_respected
28_plain_text_passwords_over_nonTLS
33_smart_host_configuration
43_dovecot_shared_folder_create_subfolder_with_acls
48_check_ssl_sni
Comment 1 Sönke Schwardt-Krummrich univentionstaff 2020-10-20 16:51:09 CEST
For now 00check_forward_secrecy has been fixed.

Package: ucs-test
Version: 10.0.1-22A~5.0.0.202010201645
Branch: ucs_5.0-0
Comment 2 Florian Best univentionstaff 2021-03-01 17:44:09 CET
git:6ed0b4f52d8dc16351be5921646159eeb4043e02 changed the product (listener module). Therefor I change the product from UCS-Test to UCS.
A changelog entry is necessary.
Comment 3 Jan Luttermann univentionstaff 2021-03-03 10:31:31 CET
Mail-Tests 24 and 33 were related to the DNS server not running. This was caused by univention-mail-postfix being not installed because mail-transport-agent was already installed. -> mail-transport-agent dependency was removed as a solution because of mail-transport-agent also bringing the needed dependencies.

Mail-Test 47_mailForwardAddress_corner_cases failed because of the filter that was set in the dovecot_shared_folder handler. case sensitivity led the handler not processing the request. -> The failing part of the filter functionality was moved to the handler-function so that filter and udm-object-values could be lowered.
Comment 4 Jan Luttermann univentionstaff 2021-03-03 12:38:47 CET
Test 28_plain_text_passwords_over_nonTLS is handled with Bug #52724
Test 48_check_ssl_sni was a timining issue. closed with commit: c0be6eae1a0e8b01fd8977fc3ebef67aac3c6b5c
Test 25_imap_acls_correctly_respected was failing due to changes to the imap base library
Test 43_dovecot_shared_folder_create_subfolder_with_acls was caused due to side effects of a multiple logins/logouts and object references. Solved by keeping the first user object. commit: ba614c4b991a42e97779ba9109447d1ecaa19ef7
Comment 5 Sönke Schwardt-Krummrich univentionstaff 2021-03-08 17:40:32 CET
(In reply to Sönke Schwardt-Krummrich from comment #0)
> There are several mail tests that are failing under UCS 5:
> 
> 00check_forward_secrecy
→ OK, see bug 51630

> 24_mailHomeServer
> 33_smart_host_configuration
→ OK, fixed via bug 52807

> 25_imap_acls_correctly_respectedbug 51629

> 43_dovecot_shared_folder_create_subfolder_with_acls
> 48_check_ssl_sni

(In reply to Jan Luttermann from comment #3)
> Mail-Tests 24 and 33 were related to the DNS server not running. This was
> caused by univention-mail-postfix being not installed because
> mail-transport-agent was already installed. -> mail-transport-agent
> dependency was removed as a solution because of mail-transport-agent also
> bringing the needed dependencies.
→ OK

(In reply to Jan Luttermann from comment #4)
> Test 28_plain_text_passwords_over_nonTLS is handled with Bug #52724
→ OK

> Test 48_check_ssl_sni was a timining issue. closed with commit:
> c0be6eae1a0e8b01fd8977fc3ebef67aac3c6b5c
→ OK

> Test 25_imap_acls_correctly_respected was failing due to changes to the imap
> base library
→ OK, bug 51629

> Test 43_dovecot_shared_folder_create_subfolder_with_acls was caused due to
> side effects of a multiple logins/logouts and object references. Solved by
> keeping the first user object. commit:
> ba614c4b991a42e97779ba9109447d1ecaa19ef7
→ OK

> Mail-Test 47_mailForwardAddress_corner_cases failed because of the filter
> that was set in the dovecot_shared_folder handler. case sensitivity led the
> handler not processing the request. -> The failing part of the filter
> functionality was moved to the handler-function so that filter and
> udm-object-values could be lowered.

Within the package univention-mail-dovecot the listener module 
dovecot-shared-folder.py has been altered. The listener module now triggers for any mail folder object and the handler function checks if the local system is affected.

univention-mail-dovecot (6.0.1-4) unstable; urgency=medium
/var/univention/buildsystem2/apt/ucs_5.0-0/all/univention-mail-dovecot_6.0.1-4A~5.0.0.202103011557_all.deb
→ imported and built
→ OK

(In reply to Florian Best from comment #2)
> git:6ed0b4f52d8dc16351be5921646159eeb4043e02 changed the product (listener
> module). Therefor I change the product from UCS-Test to UCS.
> A changelog entry is necessary.

Added missing changelog.xml entry:
[5.0-0] 6518d1cd9d Bug #52241: add changelog.xml entry
Comment 6 Florian Best univentionstaff 2021-03-09 14:46:57 CET
(In reply to Sönke Schwardt-Krummrich from comment #5)
> > Mail-Test 47_mailForwardAddress_corner_cases failed because of the filter
> > that was set in the dovecot_shared_folder handler. case sensitivity led the
> > handler not processing the request. -> The failing part of the filter
> > functionality was moved to the handler-function so that filter and
> > udm-object-values could be lowered.
> 
> Within the package univention-mail-dovecot the listener module 
> dovecot-shared-folder.py has been altered. The listener module now triggers
> for any mail folder object and the handler function checks if the local
> system is affected.

Why did this work in UCS 4.4? Did it?
I am not sure that the fix is correct.
Maybe we have a problem in the Python-3 migration of the C part of the listener - which causes a loss of case insensitivity? doubt it.
Comment 7 Florian Best univentionstaff 2021-03-09 15:42:20 CET
(In reply to Florian Best from comment #6)
> (In reply to Sönke Schwardt-Krummrich from comment #5)
> > > Mail-Test 47_mailForwardAddress_corner_cases failed because of the filter
> > > that was set in the dovecot_shared_folder handler. case sensitivity led the
> > > handler not processing the request. -> The failing part of the filter
> > > functionality was moved to the handler-function so that filter and
> > > udm-object-values could be lowered.
> > 
> > Within the package univention-mail-dovecot the listener module 
> > dovecot-shared-folder.py has been altered. The listener module now triggers
> > for any mail folder object and the handler function checks if the local
> > system is affected.
> 
> Why did this work in UCS 4.4? Did it?
> I am not sure that the fix is correct.
> Maybe we have a problem in the Python-3 migration of the C part of the
> listener - which causes a loss of case insensitivity? doubt it.

And FYI: the schema defines it as case-insensitive:
114 attributetype ( 1.3.6.1.4.1.10176.1010.1.60 NAME 'univentionMailHomeServer'
115 »   DESC 'home server of users mailbox'
116 »   EQUALITY caseIgnoreMatch
117 »   SUBSTR caseIgnoreSubstringsMatch
118 »   SYNTAX 1.3.6.1.4.1.1466.115.121.1.15{256} SINGLE-VALUE )
Comment 8 Florian Best univentionstaff 2021-05-25 16:03:28 CEST
UCS 5.0 has been released:
 https://docs.software-univention.de/release-notes-5.0-0-en.html
 https://docs.software-univention.de/release-notes-5.0-0-de.html

If this error occurs again, please use "Clone This Bug".