First Last Prev Next    This bug is not in your last search results.
Bug 52303 - Fetching meta.json should not involve UMC unless the user really needs it
Fetching meta.json should not involve UMC unless the user really needs it
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC (Generic)
UCS 4.4
Other Linux
: P5 normal (vote)
: UCS 4.4-6-errata
Assigned To: Dirk Wiesenthal
Florian Best
:
Depends on:
Blocks: 52897
  Show dependency tree / graph
 
Reported: 2020-11-03 05:39 CET by Dirk Wiesenthal
Modified: 2021-03-11 15:26 CET (History)
1 user (show)

See Also:
What kind of report is it?: Feature Request
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Wiesenthal univentionstaff 2020-11-03 05:39:29 CET 
The portal includes the UMC JS framework. Therefore, we always request meta.json. This is actually needed, but there is no need for the "dynamic part" that the UMC server adds to the response. The portal can work with a file shipped by Apache alone.
Comment 1 Dirk Wiesenthal univentionstaff 2020-11-03 06:26:51 CET 
This is done in 69b1ccdf2f

The initial call to the meta will always stop at apache:
  /univention/meta.json

This includes information like domainname. But this was already "leaked" before via anonymous UMC calls.
We may want to rm /etc/univention/templates/files/usr/share/univention-management-console/meta.json in an upgrade. Currently, it is just a leftover. The template was moved.

We now have a umcConfig.anonymousMeta which even prevents loading get/meta when logged in. It is used by the portal's index.html.
Comment 2 Dirk Wiesenthal univentionstaff 2020-11-03 10:26:42 CET 
Currently, the server name is not shown in the user menu. It used to be

Administrator
@$hostname

Now it is just

Administrator
@

Due to the missing value in the meta.json.
Comment 3 Dirk Wiesenthal univentionstaff 2020-11-03 10:47:24 CET 
Fixed by removing the "@" in case umc.tools.status("hostname") is empty. (Comment 2 and this only affected the portal)
Comment 4 Florian Best univentionstaff 2020-11-04 21:02:30 CET 
We should also set the flag to prevent the real fetching in the dojo configuration for SAML (simplesamlphp). I guess/hope the extended meta.json is not required there.
Comment 5 Dirk Wiesenthal univentionstaff 2020-11-17 21:54:01 CET 
Fixed in
univention-system-setup 12.0.2-29A~4.4.0.202011172052
univention-management-console 11.0.5-17A~4.4.0.202011172055
univention-web 3.0.5-50A~4.4.0.202011172057
univention-portal 3.0.2-13A~4.4.0.202011172128
Comment 6 Dirk Wiesenthal univentionstaff 2020-11-17 22:11:58 CET 
(In reply to Florian Best from comment #4)
> We should also set the flag to prevent the real fetching in the dojo
> configuration for SAML (simplesamlphp). I guess/hope the extended meta.json
> is not required there.

Done in
  univention-saml 6.0.2-59A~4.4.0.202011172209
Comment 7 Florian Best univentionstaff 2020-11-18 14:09:51 CET 
OK: static meta.json replacement
OK: portal
OK: simplesamlphp login
FYI: piwik now doesn't get the system-uuid and ucs-version of logged anymore

~: mv_conffile seems not move modified conffiles
I think a rm_conffile '/usr/share/univention-management-console/meta.json' is needed

OK: YAML
Comment 8 Florian Best univentionstaff 2020-11-18 17:03:56 CET 
OK: upgrade
modified templates will be stored in:
/etc/univention/templates/files/usr/share/univention-management-console/meta.json.dpkg-bak
First Last Prev Next    This bug is not in your last search results.