Bug 52897 - Fetching meta.json should not involve UMC unless the user really needs it
Summary: Fetching meta.json should not involve UMC unless the user really needs it
Status: CLOSED FIXED
Alias: None
Product: UCS
Classification: Unclassified
Component: UMC (Generic)
Version: UCS 5.0
Hardware: Other Linux
: P5 normal
Target Milestone: UCS 5.0
Assignee: Dirk Wiesenthal
QA Contact: Florian Best
URL:
Keywords:
Depends on: 52303
Blocks:
  Show dependency treegraph
 
Reported: 2021-03-11 15:26 CET by Dirk Wiesenthal
Modified: 2021-05-25 16:03 CEST (History)
1 user (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Customer ID:
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Wiesenthal univentionstaff 2021-03-11 15:26:42 CET
Needs a port to 5.0

+++ This bug was initially created as a clone of Bug #52303 +++

The portal includes the UMC JS framework. Therefore, we always request meta.json. This is actually needed, but there is no need for the "dynamic part" that the UMC server adds to the response. The portal can work with a file shipped by Apache alone.
Comment 1 Dirk Wiesenthal univentionstaff 2021-03-11 15:47:45 CET
I cherry-picked
  4d11a521540c654f5523af5d7aafe2a6bf9ea6ac
  4416e282cea3c30d0331af9c6d24863a9b584bcb
  5e86db4a74f1add9f4d472a85473341c13e97463

The rest was Changelog or the maintainer script. As this has already been released in 4.4-6, this script has already been executed (and was buggy anyway?).

No changelog needed, as it has already been a YAML in 4.4-6.
Comment 2 Dirk Wiesenthal univentionstaff 2021-03-11 16:01:20 CET
Fixed in
  univention-system-setup 13.0.3-12A~5.0.0.202103111546
  univention-management-console 12.0.8-9A~5.0.0.202103111550
  univention-web 4.0.1-15A~5.0.0.202103111552
  univention-saml 7.0.4-3A~5.0.0.202103111559
  ucs-test 10.0.4-27A~5.0.0.202103111601

univention-portal does not need any patch as it will be rewritten.
Comment 3 Florian Best univentionstaff 2021-03-12 10:04:07 CET
The test case fails:

https://jenkins.knut.univention.de:8181/job/UCS-5.0/job/UCS-5.0-0/view/Default/job/AutotestJoin/lastCompletedBuild/SambaVersion=no-samba,Systemrolle=member/testReport/01_base/95rename_administrator/member096/

[2021-03-12 00:24:14.152484] Checking template /var/www/univention/meta.json
[2021-03-12 00:24:14.152704]   "administrator": "Administrator",
[2021-03-12 00:24:14.152980] ### FAIL ###
[2021-03-12 00:24:14.153030] FAIL: Old group name Administrator still in file /var/www/univention/meta.json
[2021-03-12 00:24:14.153068] ###      ###
Comment 4 Florian Best univentionstaff 2021-03-16 21:15:32 CET
(In reply to Florian Best from comment #3)
> The test case fails:
> 
> https://jenkins.knut.univention.de:8181/job/UCS-5.0/job/UCS-5.0-0/view/
> Default/job/AutotestJoin/lastCompletedBuild/SambaVersion=no-samba,
> Systemrolle=member/testReport/01_base/95rename_administrator/member096/
> 
> [2021-03-12 00:24:14.152484] Checking template /var/www/univention/meta.json
> [2021-03-12 00:24:14.152704]   "administrator": "Administrator",
> [2021-03-12 00:24:14.152980] ### FAIL ###
> [2021-03-12 00:24:14.153030] FAIL: Old group name Administrator still in
> file /var/www/univention/meta.json
> [2021-03-12 00:24:14.153068] ###      ###

Julia was so friendly and fixed it for you in git:76dca6338603f2f16041c103dfeab4108a657ef9.
Comment 5 Dirk Wiesenthal univentionstaff 2021-03-24 09:00:19 CET
Thanks!
Comment 6 Florian Best univentionstaff 2021-03-24 18:54:27 CET
OK: commits cherry picked
no changelog entry necessary
Comment 7 Florian Best univentionstaff 2021-05-25 16:03:32 CEST
UCS 5.0 has been released:
 https://docs.software-univention.de/release-notes-5.0-0-en.html
 https://docs.software-univention.de/release-notes-5.0-0-de.html

If this error occurs again, please use "Clone This Bug".