Bug 53384 – AppCenter UMC: AppCenter breaks for apps with single quote in name (Let's Encrypt)

Bug 53384 - AppCenter UMC: AppCenter breaks for apps with single quote in name (Let's Encrypt)


Summary:	AppCenter UMC: AppCenter breaks for apps with single quote in name (Let's Enc...

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	UMC - App-Center
Version:	UCS 5.0
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 5.0-0-errata
Assigned To:	Dirk Wiesenthal
QA Contact:	Jürn Brodersen

URL:
Keywords:

Depends on:
Blocks:	53393 53412
	Show dependency tree / graph

Reported:	2021-06-02 17:37 CEST by Jürn Brodersen
Modified:	2021-06-22 08:30 CEST (History)
CC List:	3 users (show)

See Also:
What kind of report is it?:	Development Internal
What type of bug is this?:	7: Crash: Bug causes crash or data loss
Who will be affected by this bug?:	5: Will affect all installed domains
How will those affected feel about the bug?:	3: A User would likely not purchase the product
User Pain:	0.600
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):	Security
Max CVSS v3 score:

Attachments
Temporary fix (801 bytes, patch) 2021-06-02 17:37 CEST, Jürn Brodersen	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jürn Brodersen

2021-06-02 17:37:42 CEST

Created attachment 10744 [details]
Temporary fix

AppCenter UMC: AppCenter breaks for apps with single quote in name (Let's Encrypt)

If apps contain a single quote in their name the appcenter javascript breaks.

How to reproduce:
activate the test appcenter
Open the Let's Encrypt app

I attached a temporary fix which fixes single quotes but breaks double quotes...

Comment 1 Dirk Wiesenthal

2021-06-07 00:18:44 CEST

Dojo's data-dojo-props seem to be broken for dynamic values.

Fixed it as good as I could for AppInfo.js in

5342a03adb73d5984eede287981b127800b8d556 Bug #53384: Handle template error when opening Apps
Package: univention-appcenter
Version: 9.0.2-49A~5.0.0.202106070013
Branch: ucs_5.0-0
Scope: errata5.0-0

There may be more problems if the translations include a single quote (e.g., in French). For now we should at least be able to view Let's encrypt again.

I will open a new bug for the rest of data-dojo-props after some consultation.

Comment 2 Jürn Brodersen

2021-06-08 12:06:18 CEST

Changes -> OK
Let's Encrypt can be opened -> OK
jenkins -> OK
YAML -> OK

Comment 3 Erik Damrose

2021-06-09 19:26:00 CEST

<https://errata.software-univention.de/#/?erratum=5.0x9>

Comment 4 Florian Best

2021-06-22 08:30:47 CEST

*** Bug 53494 has been marked as a duplicate of this bug. ***