Bug 54054 - Update aiohttp to 3.8.0 in UDM REST API Python client
Update aiohttp to 3.8.0 in UDM REST API Python client
Status: CLOSED FIXED
Product: Components
Classification: Unclassified
Component: udm-rest-api-client
unspecified
Other Linux
: P5 normal (vote)
: ---
Assigned To: Daniel Tröder
Jürn Brodersen
:
Depends on:
Blocks: 54066
  Show dependency treegraph
 
Reported: 2021-11-11 15:51 CET by Daniel Tröder
Modified: 2021-11-19 09:35 CET (History)
2 users (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: 3: Simply Wrong: The implementation doesn't match the docu
Who will be affected by this bug?: 1: Will affect a very few installed domains
How will those affected feel about the bug?: 2: A Pain – users won’t like this once they notice it
User Pain: 0.034
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number: 2021110421000456
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Tröder univentionstaff 2021-11-11 15:51:44 CET
Version 3.8.0 contains a fix for aiohttp ignoring the "no_proxy" env setting:
* https://github.com/aio-libs/aiohttp/issues/4431
* https://github.com/aio-libs/aiohttp/releases/tag/v3.8.0

The UDM REST API Python client currently uses aiohttp version 3.7.4.

The Kelvin REST API uses the UDM REST API Python client and a custom has a proxy setting with an exclusion using "no_proxy", which is currently being ignored.
Comment 3 Daniel Tröder univentionstaff 2021-11-15 17:14:46 CET
Fixed in version 1.0.4.

[master 10ee1df] version 1.0.4, update aiohttp to handle 'no_proxy' setting (Bug #54054)
[master] 25c0e85 update travis link
[master] b0e1d20 fix RTD build

A tag "1.0.4" was added.
Various fixes to tests and the building of the docs at RTD were applied.

* Coverage: https://app.codecov.io/gh/univention/python-udm-rest-api-client
* Docs: https://udm-rest-client.readthedocs.io/en/latest/
* Travis CI: https://app.travis-ci.com/github/univention/python-udm-rest-api-client
* GH Actions - Linting: https://github.com/univention/python-udm-rest-api-client/actions?query=workflow%3A%22Code+Linting%22
* GH Actions - Integration tests: https://github.com/univention/python-udm-rest-api-client/actions?query=workflow%3A%22Integration+tests%22

The package was released on https://test.pypi.org/project/udm-rest-client/1.0.4/
When approved by QA, I'll release it via production PyPI.
Comment 5 Jürn Brodersen univentionstaff 2021-11-18 17:51:45 CET
Looks good:
Changes -> OK
Tests -> OK
Kelvin Tests -> OK

-> Approved for release

-> reopen for release to production PyPI.
Comment 6 Daniel Tröder univentionstaff 2021-11-19 08:37:13 CET
https://pypi.org/project/udm-rest-client/1.0.4/
Comment 7 Jürn Brodersen univentionstaff 2021-11-19 09:34:47 CET
Release -> OK

-> Verified
Comment 8 Jürn Brodersen univentionstaff 2021-11-19 09:35:08 CET
Already released -> Closed