Bug 54336 – 61_notifier_protocol_version fails on non-primary even on fresh installations

Bug 54336 - 61_notifier_protocol_version fails on non-primary even on fresh installations


Summary:	61_notifier_protocol_version fails on non-primary even on fresh installations

Status:	VERIFIED FIXED

Product:	UCS
Classification:	Unclassified
Component:	UMC - System diagnostic
Version:	UCS 4.4
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	UCS 5.0-1-errata
Assigned To:	Maximilian Janßen
QA Contact:	Florian Best

URL:	https://git.knut.univention.de/univen...
Keywords:

Depends on:	54264
Blocks:
	Show dependency tree / graph

Reported:	2022-01-14 10:09 CET by Julia Bremer
Modified:	2022-01-26 20:42 CET (History)
CC List:	3 users (show)

See Also:
What kind of report is it?:	Bug Report
What type of bug is this?:	3: Simply Wrong: The implementation doesn't match the docu
Who will be affected by this bug?:	1: Will affect a very few installed domains
How will those affected feel about the bug?:	2: A Pain – users won’t like this once they notice it
User Pain:	0.034
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):	bitesize
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Julia Bremer

2022-01-14 10:09:51 CET

The ucr variable notifier/protocol/version is checked in a new diagnostic module since Bug #50733. 
This check fails even on fresh UCS5 installations if the diagnostic module is installed on e.g replica- or memberservers
since the ucr variable is only set when the univention-directory-notifier is installed.

Maybe the check should be skipped if the notifier is not installed to avoid confusion.

Comment 1 Erik Damrose

2022-01-14 11:39:36 CET

After fixing this bug, revert the skipping of the checks in ucs-test by reverting git commits f6321a78 and 6e1b818d

Comment 2 Florian Best

2022-01-14 13:54:37 CET

For example https://jenkins.knut.univention.de:8181/job/UCS-5.0/job/UCS-5.0-1/view/Default/job/AutotestUpgrade/38/SambaVersion=no-samba,Systemrolle=member/testReport/00_checks/81_diagnostic_checks/test_run_diagnostic_checks/ failed.

Comment 3 Maximilian Janßen

2022-01-26 14:33:09 CET

univention-management-console-module-diagnostic.yaml
8dcc1814f05b | Bug #54336: yaml

ucs-test (10.0.6-95)
ec76712270b0 | Bug #54336: adjust notifier-protocol-version-test for memberserver

Package: univention-management-console-module-diagnostic
Version: 6.0.0-20A~5.0.0.202201211903
Branch: 5.0-1

Comment 4 Florian Best

2022-01-26 15:37:23 CET

OK: 61_notifier_protocol_version is skipped on non-master/backup
OK: test is not skipped anymore
OK: no advisory/yaml entry necessary as the plugin is not yet released.

Comment 5 Arvid Requate

2022-01-26 20:35:44 CET

Since the package has been rebuilt, the existing advisory needs to be updated,
otherwise Bug #53969 e.g. cannot be released.

Comment 6 Florian Best

2022-01-26 20:41:14 CET

(In reply to Arvid Requate from comment #5)
> Since the package has been rebuilt, the existing advisory needs to be
> updated,
> otherwise Bug #53969 e.g. cannot be released.

Well okay but this is just a fixup for the not released Bug #54264. So what to write into the YAML? I don't think for this case a YAML entry is required.
I can mark it as duplicate of Bug #54264 otherwise.

Comment 7 Arvid Requate

2022-01-26 20:42:19 CET

Ah sorry, already don via 8dcc1814f0