Bug 54682 - Update Samba to 4.16
Update Samba to 4.16
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: Samba
UCS 5.0
Other Linux
: P5 normal (vote)
: UCS 5.0-2
Assigned To: Julia Bremer
Arvid Requate
:
Depends on:
Blocks: ucs502meta
  Show dependency treegraph
 
Reported: 2022-04-22 09:29 CEST by Julia Bremer
Modified: 2022-07-04 14:08 CEST (History)
1 user (show)

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Julia Bremer univentionstaff 2022-04-22 09:29:04 CEST
We should increase our samba version to 4.16.0 

https://www.samba.org/samba/history/samba-4.16.0.html
Comment 1 Julia Bremer univentionstaff 2022-05-04 09:52:14 CEST
I updated the samba packages to 4.16.1. All built in scope samba4.16

Successful build
Package: samba
Version: 2:4.16.1-1A~5.0.0.202205031806
Branch: ucs_5.0-0
Scope: samba4.16
User: jbremer

Successful build
Package: tevent
Version: 0.11.0-1A~5.0.0.202204221325
Branch: ucs_5.0-0
Scope: samba4.16

Successful build
Package: talloc
Version: 2.3.3-1A~5.0.0.202204221525
Branch: ucs_5.0-0
Scope: samba4.16

Successful build
Package: tdb
Version: 1.4.6-1A~5.0.0.202204251320
Branch: ucs_5.0-0
Scope: samba4.16

Successful build
Package: ldb
Version: 2:2.5.0-1A~5.0.0.202204251406
Branch: ucs_5.0-0
Scope: samba4.16

Successful build
Package: univention-ldb-modules
Version: 8.0.0-6A~5.0.0.202205011311
Branch: ucs_5.0-0
Scope: samba4.16

Only minor changes to the patches were needed, e.g 
r19594 and r19591


Changes to univention-s4-conenctor and univention-samba4 are necessary, they are also built in scope samba4.16


Successful build
Package: univention-samba4
Version: 9.0.6-13-1A~5.0.0.202205020837
Branch: ucs_5.0-0
Scope: samba4.16

Successful build
Package: univention-s4-connector
Version: 14.0.7-8-1A~5.0.0.202205020839
Branch: ucs_5.0-0
Scope: samba4.16

I tested basic functionality of s4connector etc. also functionality on school servers.
I tested join of Windows clients to ucr and to ucs@school. 

I've run tests here:
https://univention-dist-jenkins.k8s.knut.univention.de/job/Mitarbeiter/job/jbremer/

They were almost completely successful. 
For ucs@school some test changes are necessary, they are in ucs@school repo branch jbremer/samba4.16. 

One test got flakier. 53_samba-common/38_printer_special_chars. 
The issue is only reproducible if I execute the whole test section, not just the test by itself. 
I'll have some closer looks into it, but I don't think this blocks QA or release. 

Please reopen for the merge to 5.0-2 after QA.
Comment 2 Arvid Requate univentionstaff 2022-05-10 20:30:33 CEST
Ok LGTM, as discussed:
* univention-ad-connector strill uses --debug-stderr
* Advisories
Comment 3 Julia Bremer univentionstaff 2022-06-20 09:44:59 CEST
1fdff7acd5 Bug #54682: Option --debug-stderr has been removed from ldb-tools
6b83619783 Bug #54682: Adapt univention-samba4 / univention-s4-connector to new samba upstream

Successful build
Package: talloc
Version: 2.3.4-1A~5.0.0.202206171836
Branch: ucs_5.0-0
Scope: ucs5.0-2


Successful build
Package: tevent
Version: 0.12.1-1A~5.0.0.202206171838
Branch: ucs_5.0-0
Scope: ucs5.0-2

Successful build
Package: tdb
Version: 1.4.7-1A~5.0.0.202206171840
Branch: ucs_5.0-0
Scope: ucs5.0-2

Successful build
Package: ldb
Version: 2:2.5.1-1A~5.0.0.202206171844
Branch: ucs_5.0-0
Scope: ucs5.0-2

Successful build
Package: samba
Version: 2:4.16.2-1A~5.0.0.202206171854
Branch: ucs_5.0-0
Scope: ucs5.0-2

Successful build
Package: univention-ldb-modules
Version: 8.0.0-7A~5.0.0.202206171906
Branch: ucs_5.0-0
Scope: ucs5.0-2

Build and merged in 5.0-2
Comment 4 Arvid Requate univentionstaff 2022-06-23 18:49:19 CEST
I've added:
e5fbbf963e | changelog-5.0-2.xml

Package was rebuilt after updating some debian/*.install and debian/patches files
according to the current package in Debian bookworm.

Package: samba
Version: 2:4.16.2-1A~5.0.0.202206221512

There's an issue with the merged UCS patches:
* I guess repo-ng copied 5.0-0-0-ucs/2:4.13.7-1 during package import
  instead of 2:4.13.13-1-errata5.0-1
* thus, e.g. changes r19447 and r19448 in 5.0-0-0-ucs/2:4.13.13-1-errata5.0-1/
  have not been taken over to 2:4.16.2-1-ucs5.0-2, thus
  * some DISABLED patches missing in 4.13.13 reappeared but that's ok:
    * 99_bug42859.quilt.DISABLED
    * 99_bug49935.quilt.DISABLED
    * 99_bug53068-CVE-2021-20254-buffer-overrun-in-sids_to_unixids.quilt.DISABLED
  * some reordered patches have their pre-Bug 54013 order, but that's ok.
  * Reopen: r19507 (for Bug #53629) got lost too!
Comment 5 Julia Bremer univentionstaff 2022-06-24 09:47:02 CEST
r19645
r19644

I merged the changes from 4.13.13 to 5.16.2

Successful build
Package: samba
Version: 2:4.16.2-1A~5.0.0.202206240840
Branch: ucs_5.0-0
Scope: ucs5.0-2
User: jbremer
Comment 6 Arvid Requate univentionstaff 2022-06-27 18:34:48 CEST
Verified:
* UCS 4.16.2 imported
* Patches from errata5.0-1 merged and adjusted
* Manual univention-upgrade on Primary & Backup
* Integration tests
* Windows 10 client join
* Memberserver join & home share access
* UCS 5.0-2 changelog
* Upstream release notes checked
* No documentation adjustment required
Comment 7 Julia Bremer univentionstaff 2022-07-04 14:01:12 CEST
Has been released with UCS 5.0-2
Comment 8 Florian Best univentionstaff 2022-07-04 14:08:20 CEST
UCS 5.0-2 has been released.

https://docs.software-univention.de/release-notes-5.0-2-en.html

If this error occurs again, please clone this bug.