Bug 54793 - Syntax check for School-OU name only done on singleserver
Summary: Syntax check for School-OU name only done on singleserver
Status: CLOSED FIXED
Alias: None
Product: UCS@school
Classification: Unclassified
Component: HTTP-API (Kelvin)
Version: UCS@school 5.0
Hardware: Other Linux
: P5 normal
Target Milestone: ---
Assignee: Johannes Königer
QA Contact: Tobias Wenzel
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-24 13:24 CEST by Tobias Wenzel
Modified: 2023-05-26 15:36 CEST (History)
1 user (show)

See Also:
What kind of report is it?: Bug Report
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Customer ID:
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Wenzel univentionstaff 2022-05-24 13:24:28 CEST
The regex for characters in an OU-name and their order is only applied, when an OU is created on a singleserver system. On multiserver systems this allows for invalid OU-names.

Make sure the naming restrictions for OU-names are also applied on multiserver systems.

This is implemented for ucsschool 5.0 in https://forge.univention.org/bugzilla/show_bug.cgi?id=53506

We also need this for the ucsschool-kelvin-rest-api.
Comment 2 Johannes Königer univentionstaff 2022-06-01 16:05:02 CEST
Resolved with merge request 
https://git.knut.univention.de/univention/components/ucsschool-kelvin-rest-api/-/merge_requests/7 

The changes: Removed the "single server"-condition in the ´validate´ method of the SchoolName class, the regex is hence checked regardless of the school server type. Additionally, a new test has been added which checks if the expected exception is raised if an invalid school name used.
Comment 3 Tobias Wenzel univentionstaff 2022-06-01 16:59:13 CEST
QA 

review done on mr + gitlab issue
all ok: verify
Comment 4 Tobias Wenzel univentionstaff 2022-06-24 08:37:05 CEST
Released with 1.5.5 -> closing this issue.