Univention Bugzilla – Bug 55884
[5.0] hard coded 'admins-' group prefix in ucsschool.lib.consistency
Last modified: 2024-03-21 15:49:46 CET
The diagnostic module shows errors, when a customer uses non-standard prefix for the school admins group (default is 'admins-'). The prefix con be configured with UCRV ucsschool/ldap/default/groupprefix/admins. ucsschool.lib.consistency correctly uses the UCRV in UserCheck.__init__(), but forgets to do that in check_mandatory_groups_exist() -> mandatory_groups[-1]. It should either use the UCRV like in __init__() or better also change that code to use SchoolSearchBase([ou]).admins_group.
As discussed - Merged and built: Package: ucs-school-lib Version: 13.0.44 Branch: ucs_5.0-0 Scope: ucs-school-5.0 --- Package: ucs-test-ucsschool Version: 7.3.162 Branch: ucs_5.0-0 Scope: ucs-school-5.0
Created attachment 11193 [details] before fix behaviour before fix
Manual QA in a multiserver env, on primary: - [x] manual QA -> see below - [x] code review - [x] changelog ok - [x] advisory ok - [x] tests pass on vm univention-app info UCS: 5.0-6 errata916 Installed: self-service-backend=5.0 ucsschool=5.0 v4 Behavior before fix: $ ucr set ucsschool/ldap/default/groupprefix/admins="super_people-" service univention-management-console-server restart I renamed the admins group of the existing groups and put the `demo_admin` in this group - cn=admins-DEMOSCHOOL,cn=ouadmins,cn=groups,dc=school,dc=test - cn=admins-school1,cn=ouadmins,cn=groups,dc=school,dc=test - cn=admins-school2,cn=ouadmins,cn=groups,dc=school,dc=test by renaming them in the UMC groups module to have the prefix `super_people-`, .e.g. `super_people-DEMOSCHOOL`. This way they are part of the correct group, only the UCR-variable is not correct. -> see attachment After the fix, I didn't get a warning.
Fix test wrong group membership As discussed - merged and built Package: ucs-test-ucsschool Version: 7.3.165 Branch: ucs_5.0-0 Scope: ucs-school-5.0
Thanks for fixing the test. Setting to verify.
UCS@school 5.0 v5 has been released. - https://docs.software-univention.de/ucsschool-changelog/5.0v5/en/changelog.html - https://docs.software-univention.de/ucsschool-changelog/5.0v5/de/changelog.html If this error occurs again, please clone this bug.