Bug 55885 – [Kelvin] hard coded 'admins-' group prefix in ucsschool.lib.consistency

Bug 55885 - [Kelvin] hard coded 'admins-' group prefix in ucsschool.lib.consistency


Summary:	[Kelvin] hard coded 'admins-' group prefix in ucsschool.lib.consistency

Status:	NEW

Product:	UCS@school
Classification:	Unclassified
Component:	HTTP-API (Kelvin)
Version:	UCS@school 5.0
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	---
Assigned To:	UCS@school maintainers
QA Contact:

URL:
Keywords:

Depends on:	55884
Blocks:
	Show dependency tree / graph

Reported:	2023-03-16 15:37 CET by Daniel Tröder
Modified:	2023-04-13 17:10 CEST (History)
CC List:	1 user (show)

See Also:
What kind of report is it?:	Bug Report
What type of bug is this?:	3: Simply Wrong: The implementation doesn't match the docu
Who will be affected by this bug?:	1: Will affect a very few installed domains
How will those affected feel about the bug?:	1: Nuisance – not a big deal but noticeable
User Pain:	0.017
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):	bitesize
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Daniel Tröder

2023-03-16 15:37:03 CET

+++ This bug was initially created as a clone of Bug #55884 +++

The diagnostic module shows errors, when a customer uses  non-standard prefix for the school admins group (default is 'admins-').

The prefix con be configured with UCRV ucsschool/ldap/default/groupprefix/admins.

ucsschool.lib.consistency correctly uses the UCRV in UserCheck.__init__(), but forgets to do that in check_mandatory_groups_exist() -> mandatory_groups[-1].

It should either use the UCRV like in __init__() or better also change that code to use SchoolSearchBase([ou]).admins_group.