Bug 56397 - course_name should be more flexible to configure
course_name should be more flexible to configure
Status: NEW
Product: UCS@school
Classification: Unclassified
Component: Apple School Manager
UCS@school 5.0
Other Linux
: P5 normal (vote)
: ---
Assigned To: UCS@school maintainers
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2023-08-03 12:22 CEST by Dirk Ahrnke
Modified: 2024-03-25 13:51 CET (History)
3 users (show)

See Also:
What kind of report is it?: Feature Request
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?: Yes
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Usability
Max CVSS v3 score:
best: Patch_Available+


Attachments
Patch for generating a valid school class description (554 bytes, patch)
2023-11-02 11:57 CET, wk
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Ahrnke univentionstaff 2023-08-03 12:22:29 CEST
The behaviour to generate the course_name has been changed a couple of times (Bug 48323 and Bug 52343)
ATM we only have the ability to change the format, e.g. from "OU-groupname" to "groupname_OU" using UCRV "asm/attributes/course-name-pattern". 
This is based on the assumption that the school-OU as well as the name of the group is human-readable. When implementing larger School-IDMs for federal states both attributes/properties may rather follow rules that are unreproducible for teachers for example "100001-BWNCN3TGWEDXSLTY". But they will be faced with those names for example in the "Classroom"-App of I-Devices that are connected to ASM. 

According to [1] there is no requirement in ASM to have course_name unique. 
 
With the implementation of Bug 52060 we are rethinking the usage of class-names and will most likely also have to rework its implementation in ASMC.

My suggestion would be make the construction of "course_name" optionally configurable without touching the required uniqueness of "course_id". The current behaviour should be retained as default. 



[1]: https://support.apple.com/en-ph/guide/apple-school-manager/axm5629a4fe4/web
Comment 3 wk 2023-11-02 11:57:21 CET
Created attachment 11138 [details]
Patch for generating a valid school class description

Proposed patch for ASMC 3.0.2: using the class description as name if it's not empty.

File is /usr/lib/python3/dist-packages/univention/asm/models/models.py

This patch is currently used in a production environment.
Comment 4 Dirk Ahrnke univentionstaff 2024-03-25 13:51:22 CET
> File is /usr/lib/python3/dist-packages/univention/asm/models/models.py
> 
I guess its rather courses.py than models.py