Bug 30948 - Review UCR variable descriptions for services packages
Review UCR variable descriptions for services packages
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: General
UCS 3.0
Other Linux
: P5 normal (vote)
: UCS 3.2
Assigned To: Moritz Muehlenhoff
Philipp Hahn
: interim-2
: 7099 12984 17316 22548 22568 27802 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-03-28 14:41 CET by Moritz Muehlenhoff
Modified: 2013-11-19 06:43 CET (History)
6 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments
Fixes from QA (238.78 KB, patch)
2013-09-23 15:16 CEST, Philipp Hahn
Details | Diff
Updated patch (242.43 KB, patch)
2013-09-23 16:29 CEST, Philipp Hahn
Details | Diff
Missing "can can" → "but can" changes (15.76 KB, patch)
2013-09-24 12:20 CEST, Philipp Hahn
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Moritz Muehlenhoff univentionstaff 2013-03-28 14:41:28 CET
The UCR variable descriptions for the packages in base/ should be reviewed:

- Are descriptions missing?
- Are they comprehensible and self-contained?
- Are the syntactical options obvious for the user?
- Quality of the English translation

./univention-dansguardian/debian/univention-dansguardian.univention-config-registry-variables
./univention-apache/debian/univention-apache.univention-config-registry-variables
./univention-bacula/debian/univention-bacula.univention-config-registry-variables
./univention-snmpd/debian/univention-snmpd.univention-config-registry-variables
./univention-postgresql/debian/univention-postgresql.univention-config-registry-variables
./univention-sasl/debian/univention-sasl.univention-config-registry-variables
./univention-dhcp/debian/univention-dhcp.univention-config-registry-variables
./univention-samba/debian/univention-samba.univention-config-registry-variables
./univention-printquota/debian/univention-printquota.univention-config-registry-variables
./univention-printquota/debian/univention-printquotadb.univention-config-registry-variables
./univention-s4-connector/debian/univention-s4-connector.univention-config-registry-variables
./univention-bind/debian/univention-bind.univention-config-registry-variables
./univention-log-collector/debian/univention-log-collector-client.univention-config-registry-variables
./univention-log-collector/debian/univention-log-collector-server.univention-config-registry-variables
./univention-squid/debian/univention-squid.univention-config-registry-variables
./univention-printserver/debian/univention-printserver.univention-config-registry-variables
./univention-printserver/debian/univention-printserver-pdf.univention-config-registry-variables
./univention-nfs/debian/univention-nfs-server.univention-config-registry-variables
./univention-net-installer/debian/univention-net-installer.univention-config-registry-variables
./univention-pkgdb/debian/univention-pkgdb-tools.univention-config-registry-variables
./univention-pkgdb/debian/univention-pkgdb.univention-config-registry-variables
./univention-samba4wins/debian/univention-samba4wins.univention-config-registry-variables
./univention-samba4/debian/univention-samba4.univention-config-registry-variables
./univention-samba4/debian/univention-samba4-sysvol-sync.univention-config-registry-variables
./univention-ad-connector/debian/univention-ad-connector.univention-config-registry-variables
./univention-ad-connector/debian/univention-ad-connector-exchange.univention-config-registry-variables
Comment 1 Moritz Muehlenhoff univentionstaff 2013-05-30 13:42:33 CEST
*** Bug 7099 has been marked as a duplicate of this bug. ***
Comment 2 Moritz Muehlenhoff univentionstaff 2013-05-30 14:08:39 CEST
*** Bug 12984 has been marked as a duplicate of this bug. ***
Comment 3 Moritz Muehlenhoff univentionstaff 2013-06-27 09:57:37 CEST
*** Bug 22548 has been marked as a duplicate of this bug. ***
Comment 4 Moritz Muehlenhoff univentionstaff 2013-06-27 11:43:32 CEST
*** Bug 22568 has been marked as a duplicate of this bug. ***
Comment 5 Moritz Muehlenhoff univentionstaff 2013-07-02 16:34:33 CEST
*** Bug 17316 has been marked as a duplicate of this bug. ***
Comment 6 Moritz Muehlenhoff univentionstaff 2013-07-02 16:37:59 CEST
*** Bug 27802 has been marked as a duplicate of this bug. ***
Comment 7 Felix Botner univentionstaff 2013-08-01 14:38:04 CEST
This

svn diff -c r42372 univention-nfs/debian/univention-nfs-server.univention-config-registry
===================================================================
--- univention-nfs/debian/univention-nfs-server.univention-config-registry      (Revision 42371)
+++ univention-nfs/debian/univention-nfs-server.univention-config-registry      (Revision 42372)
@@ -14,3 +14,7 @@
 Type: file
 File: etc/modprobe.d/nfs-kernel-lockd.conf
 Variables: nfs/ports
+
+Type: file
+File: etc/init.d/nfs-kernel-server
+Variables: nfs/autostart

destroys the nfs-kernel-server (mounts on nfs exports on servers with that init script hang forever). The UCR template for etc/init.d/nfs-kernel-server is broken and has to be removed. The original init script works just fine.
Comment 8 Moritz Muehlenhoff univentionstaff 2013-08-29 13:53:07 CEST
The UCR variable descriptions for the following packages have been revised:

univention-log-collector
univention-ad-connector
univention-apache
univention-printserver
univention-postgresql
univention-dhcp
univention-nfs
univention-s4-connector
univention-samba
univention-snmpd
univention-samba4
univention-check-printers
univention-bind
univention-bacula
univention-net-installer
univention-printquota
univention-pkgdb
univention-dansguardian
univention-squid
Comment 9 Philipp Hahn univentionstaff 2013-09-23 15:16:49 CEST
Created attachment 5458 [details]
Fixes from QA

Try "cat 30948_services_UCRV.diff | wdiff -d -l | less" for easier reading.
Comment 10 Philipp Hahn univentionstaff 2013-09-23 15:17:21 CEST
See patch:
...-connector.univention-config-registry-variables |   67 ++++++-----
...ion-apache.univention-config-registry-variables |   44 +++++---
...ion-bacula.univention-config-registry-variables |   10 +-
...ntion-bind.univention-config-registry-variables |   39 ++++---
...nsguardian.univention-config-registry-variables |   77 +++++++------
...ntion-dhcp.univention-config-registry-variables |   19 ++--
...tor-client.univention-config-registry-variables |    6 +-
...tor-server.univention-config-registry-variables |   16 +--
...-installer.univention-config-registry-variables |   20 ++--
...nfs-server.univention-config-registry-variables |   16 +--
...kgdb-tools.univention-config-registry-variables |    2 +-
...tion-pkgdb.univention-config-registry-variables |    2 +-
...postgresql.univention-config-registry-variables |   12 +-
...printquota.univention-config-registry-variables |    5 +-
...intquotadb.univention-config-registry-variables |    1 -
...server-pdf.univention-config-registry-variables |    8 +-
...rintserver.univention-config-registry-variables |   28 ++---
...-connector.univention-config-registry-variables |   94 ++++++++--------
...tion-samba.univention-config-registry-variables |  119 ++++++++++----------
...ysvol-sync.univention-config-registry-variables |    9 +-
...ion-samba4.univention-config-registry-variables |  114 ++++++++++---------
.../89univention-samba4wins-schema.inst            |    2 +-
.../90univention-samba4wins.inst                   |    2 +-
.../univention-samba4wins/debian/copyright         |    3 +-
.../services/univention-samba4wins/debian/rules    |    3 +-
.../debian/univention-samba4wins-schema.postinst   |    3 +-
.../debian/univention-samba4wins.postinst          |    3 +-
...samba4wins.univention-config-registry-variables |   15 ++-
.../univention-samba4wins/listener/samba4wins.py   |    2 +-
.../schema/univention-samba4wins.schema            |    2 +-
...ntion-sasl.univention-config-registry-variables |    6 +-
...tion-snmpd.univention-config-registry-variables |   10 +-
...tion-squid.univention-config-registry-variables |   82 +++++++-------
33 files changed, 423 insertions(+), 418 deletions(-)
Comment 11 Philipp Hahn univentionstaff 2013-09-23 16:29:10 CEST
Created attachment 5461 [details]
Updated patch

+can can → but can
Comment 12 Moritz Muehlenhoff univentionstaff 2013-09-24 09:59:05 CEST
(In reply to Felix Botner from comment #7)
> This
> 
> svn diff -c r42372
> univention-nfs/debian/univention-nfs-server.univention-config-registry
> ===================================================================
> --- univention-nfs/debian/univention-nfs-server.univention-config-registry  
> (Revision 42371)
> +++ univention-nfs/debian/univention-nfs-server.univention-config-registry  
> (Revision 42372)
> @@ -14,3 +14,7 @@
>  Type: file
>  File: etc/modprobe.d/nfs-kernel-lockd.conf
>  Variables: nfs/ports
> +
> +Type: file
> +File: etc/init.d/nfs-kernel-server
> +Variables: nfs/autostart
> 
> destroys the nfs-kernel-server (mounts on nfs exports on servers with that
> init script hang forever). The UCR template for etc/init.d/nfs-kernel-server
> is broken and has to be removed. The original init script works just fine.

Indeed. We use the standard init script from Debian (with a patch for autostart suppport), so the UCR template is obsolete. I've removed it in revision 44374
Comment 13 Moritz Muehlenhoff univentionstaff 2013-09-24 12:03:33 CEST
The patch was merged with some fixes on top (please rebase).

The change towards "an user" is not correct, see 
http://owl.english.purdue.edu/owl/resource/591/01/

The following packages were rebuilt:
univention-samba4wins
univention-printserver
univention-samba
univention-pkgdb
univention-bacula
univention-squid
univention-s4-connector
univention-net-installer
univention-dhcp
univention-apache
univention-nfs
univention-sasl
univention-samba4
univention-printquota
univention-bind
univention-snmpd
univention-ad-connector
univention-log-collector
univention-dansguardian
univention-postgresql
Comment 14 Philipp Hahn univentionstaff 2013-09-24 12:20:30 CEST
Created attachment 5466 [details]
Missing "can can" → "but can" changes
Comment 15 Moritz Muehlenhoff univentionstaff 2013-09-24 12:44:39 CEST
(In reply to Philipp Hahn from comment #14)
> Created attachment 5466 [details]
> Missing "can can" → "but can" changes

Merged and rebuilt:

univention-apache
univention-bind
univention-dansguardian
univention-dhcp
univention-nfs
univention-postgresql
univention-printserver
univention-samba
univention-samba4
Comment 16 Philipp Hahn univentionstaff 2013-09-24 16:58:23 CEST
OK: lsdiff --strip=5 ~/BUG/30948-service-UCRV-description-QA2.patch  | cut -d/ -f1 | ssh xen12 LC_ALL=C xargs apt-cache policy | grep Candidate
Comment 17 Stefan Gohmann univentionstaff 2013-11-19 06:43:25 CET
UCS 3.2 has been released:
 http://docs.univention.de/release-notes-3.2-en.html
 http://docs.univention.de/release-notes-3.2-de.html

If this error occurs again, please use "Clone This Bug".