Bug 32218 - Usability: button look
Usability: button look
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC (Generic)
UCS 3.1
All Linux
: P5 enhancement (vote)
: UCS 3.2
Assigned To: Alexander Kläser
Florian Best
: interim-3
: 32748 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-12 09:34 CEST by Philipp Hahn
Modified: 2013-11-19 06:41 CET (History)
3 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Design, Usability
Max CVSS v3 score:


Attachments
Screenshot of Updater module. (133.60 KB, image/png)
2013-10-10 17:22 CEST, Alexander Kläser
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Hahn univentionstaff 2013-08-12 09:34:01 CEST
Please convert "buttons" to real "buttons" to give the user a hint, that the "link" is in fact an action.

For example if a disk is removed from a VM in UVMM, a dialog pops up to ask the user, if the image should be "deleted", "detached" or if the user wants to abort the dialog. Only the default action has a green border, the other two actions just look like normal links with a white background.
It would help the usability to render those buttons as real buttons:

A good read: <http://www.karlgroves.com/2013/05/14/links-are-not-buttons-neither-are-divs-and-spans/>
Comment 1 Alexander Kläser univentionstaff 2013-08-12 13:36:52 CEST
Our "buttons" differ from "links" as they are black and links are green. However, I agree that this may not be very obvious.
Comment 2 Alexander Kläser univentionstaff 2013-09-30 13:06:49 CEST
*** Bug 32748 has been marked as a duplicate of this bug. ***
Comment 3 Alexander Kläser univentionstaff 2013-09-30 13:08:02 CEST
From Bug 32318:
> The default (=green) button is in FF "much" larger than in Chromium.
Comment 4 Alexander Kläser univentionstaff 2013-10-02 09:32:29 CEST
From Bug 26418, comment 14:
> Disabled actions have a greyed out icon. But as some actions do not have any
> icon and the text is not greyed out in any case, it is hard (read:
> impossible) to say whether an action is clickable or not.
> 
> Example: "Execute" in join module
Comment 5 Alexander Kläser univentionstaff 2013-10-09 17:41:23 CEST
A first version with adapted buttons has been committed:

 univention-management-console-frontend (3.0.94-1) unstable; urgency=low
 .
   * Bug #32218: adjusted button look
Comment 6 Alexander Kläser univentionstaff 2013-10-10 12:27:08 CEST
Fixed. With some adjustments in UDM.


 univention-management-console-frontend (3.0.96-1) unstable; urgency=low
 .
   * Bug #32218: CSS fine adjustments for button styling


 univention-management-console-module-udm (4.0.40-1) unstable; urgency=low
 .
   * Bug #32218: adjust translation to avoid breaking the search form layout
Comment 7 Alexander Kläser univentionstaff 2013-10-10 17:05:56 CEST
The border within the button icons has been removed as it is futile now.


 univention-management-console-frontend (3.0.101-1) unstable; urgency=low
 .
   * Bug #32218: adjust button icons to new style, CSS/HTML cleanup
Comment 8 Alexander Kläser univentionstaff 2013-10-10 17:22:39 CEST
Created attachment 5514 [details]
Screenshot of Updater module.

The button in the updater is broken (see screenshot).
Comment 9 Florian Best univentionstaff 2013-10-11 08:09:11 CEST
please have a look at system setup → network → add (InterfaceWizard IP page)
Comment 10 Philipp Hahn univentionstaff 2013-10-11 08:46:32 CEST
Maybe Bug #31411 can also be resolved while re-working the icons. Some part is already done by r44966, but the icon for "pull-the-UVMM-plug" still needs to be fixed and a button for "ACPI-shutdown" is still missing.
Comment 11 Alexander Kläser univentionstaff 2013-10-11 11:08:31 CEST
The disabled green button needs to be adapted.
Comment 12 Alexander Kläser univentionstaff 2013-10-11 11:37:39 CEST
(In reply to Alexander Kläser from comment #8)
> Created attachment 5514 [details]
> Screenshot of Updater module.
> 
> The button in the updater is broken (see screenshot).

Fixed.

 univention-updater (9.0.21-1) unstable; urgency=low
 .
   * Bug #32218: fixed styling of back button on progress page


(In reply to Florian Best from comment #9)
> please have a look at system setup → network → add (InterfaceWizard IP page)

The +/- buttons in the MultiInput widget have already been fixed.


(In reply to Philipp Hahn from comment #10)
> Maybe Bug #31411 can also be resolved while re-working the icons. Some part
> is already done by r44966, but the icon for "pull-the-UVMM-plug" still needs
> to be fixed and a button for "ACPI-shutdown" is still missing.

Revising the icons is out of scope w.r.t. this bug. I simply removed the border around the icons and adjusted +/- slightly in their size to look ok.


(In reply to Alexander Kläser from comment #11)
> The disabled green button needs to be adapted.

Fixed.

 univention-management-console-frontend (3.0.102-1) unstable; urgency=low
 .
   * Bug #32218: adjusted styling of disabled submit button
Comment 13 Alexander Kläser univentionstaff 2013-10-11 13:37:03 CEST
Added a little shadow effect to hovered buttons to make them appear more like buttons.


 univention-management-console-frontend (3.0.104-1) unstable; urgency=low
 .
   * Bug #32218: added shadow effect to hovered buttons
Comment 14 Alexander Kläser univentionstaff 2013-10-16 11:15:49 CEST
In FF, the category buttons in the live search for the overview page are rendered with a shadow.

On Android + iPad the buttons need to be adjusted slightly.
Comment 15 Erik Damrose univentionstaff 2013-10-17 10:31:31 CEST
The shadow effect is apparently applied to a button and its text. I find the text-shadow that is visible while hovering a button irritating, as the text is looking blurred. Maybe the shadow effect should be changed so that it is only visible around the button border.
Comment 16 Erik Damrose univentionstaff 2013-10-17 10:56:01 CEST
The text on some buttons can be improved: To show extended search options there is a button that has the text "(Advanced options)" on it, and its counterpart has "(Simplified options)". The parenthesis can be removed.
Comment 17 Alexander Kläser univentionstaff 2013-10-17 11:25:29 CEST
(In reply to Erik Damrose from comment #16)
> The text on some buttons can be improved: To show extended search options
> there is a button that has the text "(Advanced options)" on it, and its
> counterpart has "(Simplified options)". The parenthesis can be removed.

Good hint. Fixed.

 univention-management-console-module-udm (4.0.46-1) unstable; urgency=low
 .
   * Bug #32877: re-enable module options
   * Bug #32218: adjusted label of toggle button for search options
Comment 18 Alexander Kläser univentionstaff 2013-10-17 12:12:57 CEST
(In reply to Erik Damrose from comment #15)
> The shadow effect is apparently applied to a button and its text. I find the
> text-shadow that is visible while hovering a button irritating, as the text
> is looking blurred. Maybe the shadow effect should be changed so that it is
> only visible around the button border.

As discussed, there was another similar feedback regarding the text shadow. At the moment I would opt for leaving it like that, because (a) it was like that before and (b) I am not aware of a different and better solution.
Comment 19 Florian Best univentionstaff 2013-10-17 15:15:03 CEST
Can you add a fallback brackground color for a submit button. If the bg-image is not yet loaded the font-color and background color is white.
Comment 20 Alexander Kläser univentionstaff 2013-10-24 12:56:39 CEST
(In reply to Florian Best from comment #19)
> Can you add a fallback brackground color for a submit button. If the
> bg-image is not yet loaded the font-color and background color is white.

Good point. I also adjusted the buttons for Safari on iOS slightly, for Android they looked fine.

 univention-management-console-frontend (3.0.126-1) unstable; urgency=low
 .
   * Bug #32218: background color to default button

 univention-management-console-frontend (3.0.127-1) unstable; urgency=low
 .
   * Bug #32218: adjusted buttons for Safari on iOS
Comment 21 Florian Best univentionstaff 2013-10-24 13:26:17 CEST
(In reply to Alexander Kläser from comment #20)
> (In reply to Florian Best from comment #19)
> > Can you add a fallback brackground color for a submit button. If the
> > bg-image is not yet loaded the font-color and background color is white.
> 
> Good point. I also adjusted the buttons for Safari on iOS slightly, for
> Android they looked fine.
On hover of SubmitButton the background image is not displayed instead the background color is displayed.
Comment 22 Florian Best univentionstaff 2013-10-24 16:33:00 CEST
(In reply to Alexander Kläser from comment #12)
> (In reply to Florian Best from comment #9)
> > please have a look at system setup → network → add (InterfaceWizard IP page)
> 
> The +/- buttons in the MultiInput widget have already been fixed.
They are again unfixed.
Comment 23 Alexander Kläser univentionstaff 2013-10-25 14:13:50 CEST
Points have been addressed.

 univention-management-console-frontend (3.0.130-1) unstable; urgency=low
 .
   * Bug #30004: fixed scoping problem with addNotification in umc/widgets/Page
   * Bug #30004: make sure that "your session has expired" is not shown when
     initially loading UMC
   * Bug #32218: changed order of buttons in logout dialogue
   * Bug #32218: remove margin-rigth from "add" button in MultiInput
Comment 24 Florian Best univentionstaff 2013-10-29 11:32:30 CET
No Changelog entry exists.
Comment 25 Florian Best univentionstaff 2013-10-30 13:11:03 CET
(In reply to Florian Best from comment #24)
> No Changelog entry exists.
Everything else is fine.
Comment 26 Alexander Kläser univentionstaff 2013-10-31 18:01:16 CET
(In reply to Florian Best from comment #24)
> No Changelog entry exists.

Done.
Comment 27 Florian Best univentionstaff 2013-11-01 11:03:22 CET
Changelog OK
Comment 28 Stefan Gohmann univentionstaff 2013-11-19 06:41:27 CET
UCS 3.2 has been released:
 http://docs.univention.de/release-notes-3.2-en.html
 http://docs.univention.de/release-notes-3.2-de.html

If this error occurs again, please use "Clone This Bug".