Bug 33174 – User quota set by policy is not edited / removed upon editing / removing policy

Bug 33174 - User quota set by policy is not edited / removed upon editing / removing policy


Summary:	User quota set by policy is not edited / removed upon editing / removing policy

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	UMC - Quota
Version:	UCS 3.2
Hardware:	Other Linux

Importance:	P5 enhancement (vote)
Target Milestone:	UCS 3.2-2-errata
Assigned To:	Erik Damrose
QA Contact:	Felix Botner

URL:
Keywords:

Duplicates:	35306 (view as bug list)
Depends on:
Blocks:	33959
	Show dependency tree / graph

Reported:	2013-11-07 10:00 CET by Drees Dormann
Modified:	2014-08-07 17:48 CEST (History)
CC List:	8 users (show)

See Also:
What kind of report is it?:	---
What type of bug is this?:	---
Who will be affected by this bug?:	---
How will those affected feel about the bug?:	---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):	Usability
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Drees Dormann

2013-11-07 10:00:10 CET

when defining a user quota policy in shares => policies
quota gets set correctly as soon as someone connects to shared folder.
But upon removing the policy the quota still exists.
Also any changes made to this policy are not applied to the quota.

Comment 1 Tim Petersen

2014-01-21 08:59:05 CET

(In reply to Drees Dormann from comment #0)
> Also any changes made to this policy are not applied to the quota.

Again reported and reproduced by me at UCS 3.2-0 Errata 20

I found no way to force the updated settings - user quota always stucks at the initial values from first share connect.
As described, even removing the policy and creating a new one doesn't have any effect.

Comment 2 Stefan Gohmann

2014-01-21 09:25:34 CET

Currently that is the design of the quota policy. Maybe we should change the default behavior and add a checkbox which controls whether the value is every time newly set.

Comment 3 Erik Damrose

2014-06-30 10:53:29 CEST

The fix contains the following changes:
- user share policy has been extended by an attribute to reapply the user-share quota on each login
- univention-user-quota has been extended to evaluate the flag and reapply the quota if applicable
- If more than one user-share quotaunivention-user-quota used to calculate the correct quota values wrong. It now sets the most restrictive quota values defined for each mountpoint

r51290 univention-ldap 10.0.17-36.693.201406261204
r51291 yaml

r51293 univention-directory-manager-modules 9.0.76-6.1204.201406261244
r51294 merge to UCS 4.0 univention-directory-manager-modules 10.0.0-2
r51295 yaml

r51358 univention-quota 8.0.6-4.124.201406301032
r51359 yaml
r51360 merge to UCS 4.0; not build yet, see Bug 35139#c3

Comment 4 Erik Damrose

2014-07-01 16:05:51 CEST

(In reply to Erik Damrose from comment #3)
> r51360 merge to UCS 4.0; not build yet, see Bug 35139#c3

Bug 35138#c3

Comment 5 Felix Botner

2014-07-07 17:01:52 CEST

OK - checkbox "Reapply settings on every login"
OK - univention-user-quota
OK - YAML
OK - merged to 4.0

Comment 6 Erik Damrose

2014-07-08 12:52:00 CEST

*** Bug 35306 has been marked as a duplicate of this bug. ***

Comment 7 Erik Damrose

2014-07-08 12:53:24 CEST

From Bug 35306:
The following traceback occurs if no quota has been activated for a partition/mountpoint but a share-policy defines a quota for it.

univention-user-quota y23j4odaqi
Traceback (most recent call last):
  File "/usr/sbin/univention-user-quota", line 168, in <module>
    mountpoints = get_mountpoints_with_quota(user, shares)
  File "/usr/sbin/univention-user-quota", line 135, in get_mountpoints_with_quota
    if _mountpoints[attrs['mountpoint']][policy_value] == '0' or int(attrs[policy_value]) < int(_mountpoints[attrs['mountpoint']][policy_value]):
KeyError: '/'

Comment 8 Erik Damrose

2014-07-09 09:53:08 CEST

Fix univention-user-quota traceback if no quota is defined

r51632 univention-quota 8.0.6-8.128.201407090947
r51634 yaml

Comment 9 Erik Damrose

2014-07-09 11:36:13 CEST

r51632 Merge to UCS 4.0

Comment 10 Felix Botner

2014-07-09 11:45:57 CEST

OK (errata3.2-2, 4.0-0)
OK - YAML

Comment 11 Moritz Muehlenhoff

2014-07-14 10:51:19 CEST

http://errata.univention.de/ucs/3.2/150.html

Comment 12 Arvid Requate

2014-08-06 18:27:24 CEST

This bug number also appears in the advisory for univention-quota, which will be released in one of the next errata updates (like tomorrow).

Comment 13 Arvid Requate

2014-08-06 18:30:25 CEST

And the bug number is also refered to by an upcoming errata advisory for univention-directory-manager-modules.

Comment 14 Janek Walkenhorst

2014-08-07 17:41:44 CEST

http://errata.univention.de/ucs/3.2/158.html

Comment 15 Janek Walkenhorst

2014-08-07 17:48:27 CEST

http://errata.univention.de/ucs/3.2/170.html