Bug 33190 - Release policy layout
Release policy layout
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: UMC - Policies
UCS 4.0
Other Linux
: P5 minor (vote)
: UCS 4.0-0-errata
Assigned To: Florian Best
Alexander Kläser
:
: 36699 (view as bug list)
Depends on:
Blocks: 20962
  Show dependency treegraph
 
Reported: 2013-11-07 12:32 CET by Stefan Gohmann
Modified: 2015-02-24 08:50 CET (History)
5 users (show)

See Also:
What kind of report is it?: ---
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional): Design
Max CVSS v3 score:


Attachments
umc-policy-release.png (43.43 KB, image/png)
2013-11-07 12:32 CET, Stefan Gohmann
Details
screenshot: adjusted umc-policy-release (12.54 KB, image/png)
2014-06-26 12:58 CEST, Alexander Kramer
Details
patch adjusts the layout (690 bytes, patch)
2014-06-26 12:59 CEST, Alexander Kramer
Details | Diff
patch adjusts the layout and adapts some descriptions (2.96 KB, patch)
2014-07-15 14:34 CEST, Alexander Kramer
Details | Diff
adapted policy ger and eng preview (26.70 KB, image/png)
2014-07-22 13:30 CEST, Alexander Kramer
Details
patch adjusts the layout and adapts some descriptions (2.96 KB, patch)
2014-07-22 13:58 CEST, Alexander Kramer
Details | Diff
updated preview (26.36 KB, image/png)
2014-07-22 13:59 CEST, Alexander Kramer
Details
New patch from 2014-09-04 (6.14 KB, patch)
2014-09-04 09:56 CEST, Alexander Kramer
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Gohmann univentionstaff 2013-11-07 12:32:08 CET
Created attachment 5574 [details]
umc-policy-release.png

See screenshot, the layout should be adjusted.
Comment 1 Philipp Hahn univentionstaff 2013-11-28 14:52:58 CET
IMHO the checkbox to enable/disable the policy should be removed, as this is the only UCS policy providing such as mis-guided option. Everywhere else the policy has to be removed to un-apply the policy.
This check-box already has caused confusion in UCS technical trainings.
Comment 2 Moritz Muehlenhoff univentionstaff 2013-11-28 15:24:19 CET
(In reply to Philipp Hahn from comment #1)
> IMHO the checkbox to enable/disable the policy should be removed, as this is
> the only UCS policy providing such as mis-guided option. Everywhere else the
> policy has to be removed to un-apply the policy.
> This check-box already has caused confusion in UCS technical trainings.

Ack,there's already Bug 20962 for this, which was also suggested during a training.
Comment 3 Stefan Gohmann univentionstaff 2013-11-28 15:44:33 CET
At least in former times the updater updated to the latest version if the field release version was not set. IF the checkbox will be removed this behavior should be changed as well, otherwise all systems will be performing the update. UCS mixed scenarios should also be considered.
Comment 4 Alexander Kramer univentionstaff 2014-06-26 12:58:22 CEST
Created attachment 5973 [details]
screenshot: adjusted umc-policy-release
Comment 5 Alexander Kramer univentionstaff 2014-06-26 12:59:31 CEST
Created attachment 5974 [details]
patch adjusts the layout
Comment 6 Alexander Kramer univentionstaff 2014-06-26 13:01:04 CEST
(In reply to Stefan Gohmann from comment #0)
> Created attachment 5574 [details]
> umc-policy-release.png
> 
> See screenshot, the layout should be adjusted.

I only adjusted the layout. Did not touch Bug 20962
Comment 7 Alexander Kramer univentionstaff 2014-06-26 13:02:36 CEST
patch assigned
Comment 8 Philipp Hahn univentionstaff 2014-06-26 13:10:55 CEST
(In reply to Philipp Hahn from comment #1)
> IMHO the checkbox to enable/disable the policy should be removed, as this is
> the only UCS policy providing such as mis-guided option. Everywhere else the
> policy has to be removed to un-apply the policy.
> This check-box already has caused confusion in UCS technical trainings.

Actually the text for the checkbox is misleading, as the checkbox toggles between two modes:
- checked an release update is performed, if one is available. The text box can be used to optionally specify the maximum version to upgrade to.
- unchecked only pending packages are installed, for example errata updates.
- without a policy no package or release updates are performed.

IMHO the text should be changed as well to better reflect that and the checkbox must be located before the text entry field, to describe the dependency between them.
Comment 9 Alexander Kramer univentionstaff 2014-07-15 14:34:59 CEST
Created attachment 5996 [details]
patch adjusts the layout and adapts some descriptions

Layout:
The checkbox is now located over the text entry field

Descriptions: Adapted misleading texts (old / new)
# Policy: Release / Policy: Update
# Release / Automatic updates
The policy is also for errata-updates so it is misleading to call it 'Release'

# Activate policy / Activate release updates. (Errata updates are activated by default)
This is what the code does (see: base/univention-updater/debian/univention-updater.univention-maintenance.init)

# Release Version / Highest release version to be installed.
Also added a long_description: Without specifying the most recent version will be used
Comment 10 Alexander Kläser univentionstaff 2014-07-17 09:45:54 CEST
Alex, could you please add a little screenshot of how it looks like with the patch? Thanks :) .
Comment 11 Alexander Kramer univentionstaff 2014-07-22 13:30:46 CEST
Created attachment 6019 [details]
adapted policy ger and eng preview
Comment 12 Alexander Kramer univentionstaff 2014-07-22 13:58:53 CEST
Created attachment 6020 [details]
patch adjusts the layout and adapts some descriptions

Adapted the patch
Comment 13 Alexander Kramer univentionstaff 2014-07-22 13:59:51 CEST
Created attachment 6021 [details]
updated preview

a preview for the renamed 'release policy'
Comment 14 Alexander Kläser univentionstaff 2014-08-01 17:09:25 CEST
(In reply to Alexander Kramer from comment #13)
> Created attachment 6021 [details]
> updated preview
> 
> a preview for the renamed 'release policy'

Looks good! Suggestion for text change:

"Highest release version to be installed"
[en] → "Update up to this UCS version"
[de] → "Bis zu dieser UCS-Version aktualisieren"

It would be nice to have the release version field grayed out if the check box is disabled. This is not possible in a generic way, however, it would be possible to add into DetailPage.js (in univention-management-console-module-udm) an if-case that implements this dynamic handling for this specific policy type.

Could you have a try to implement this behaviour? If you have questions regarding the implementation, I am sure Dirk is happy to help :) .
Comment 15 Alexander Kramer univentionstaff 2014-09-04 09:54:30 CEST
(In reply to Alexander Kläser from comment #14)
> Looks good! Suggestion for text change:
> 
> "Highest release version to be installed"
> [en] → "Update up to this UCS version"
> [de] → "Bis zu dieser UCS-Version aktualisieren"
> 

I adopted the suggestions. See the new patch.
For the adaption of the de.po i used this instructions from the wiki:
https://hutten.knut.univention.de/mediawiki/index.php/Uebersetzung
It worked finde but i am a little bit unsure, if i missed something.

> It would be nice to have the release version field grayed out if the check
> box is disabled. This is not possible in a generic way, however, it would be
> possible to add into DetailPage.js (in
> univention-management-console-module-udm) an if-case that implements this
> dynamic handling for this specific policy type.
> 
> Could you have a try to implement this behaviour? If you have questions
> regarding the implementation, I am sure Dirk is happy to help :) .

For this part i would appreciate your help. I spoke with Dirk and Florian about this and both said that this is maybe no good idea.
Comment 16 Alexander Kramer univentionstaff 2014-09-04 09:56:04 CEST
Created attachment 6089 [details]
New patch from 2014-09-04
Comment 17 Alexander Kläser univentionstaff 2014-11-14 18:36:22 CET
*** Bug 36699 has been marked as a duplicate of this bug. ***
Comment 18 Alexander Kläser univentionstaff 2014-12-04 14:53:15 CET
Patch looks good, please apply to UCS4 errata scope.
Comment 19 Alexander Kramer univentionstaff 2014-12-15 10:09:15 CET
Revision 56793
univention-directory-manager-modules (10.0.29-10) 
* Bug #33190: Changed the release policy to update policy and adapted
the layout

Successful build
Package: univention-directory-manager-modules
Version: 10.0.29-10.1272.201412150955

r56796
yaml file
Comment 20 Florian Best univentionstaff 2014-12-15 10:52:56 CET
There is one untranslated string:
+			long_description='Without specifying the most recent version will be used',
Comment 21 Alexander Kramer univentionstaff 2014-12-15 12:17:38 CET
r 56809, 56810:
Added missing tranlation and adpated the changelog

Successful build
Package: univention-directory-manager-modules
Version: 10.0.29-11.1273.201412151212

r 56811
yaml file
Comment 22 Florian Best univentionstaff 2015-01-09 14:11:20 CET
Please make the following text adjustments
Activate release updates. (Errata updates are activated by default)
→ Activate release updates (Errata updates are activated by default).

Aktiviere Release-Updates. (Errata Updates sind per Default aktiviert)
→ Aktiviere Release-Updates (Errata-Updates sind standardmäßig aktiviert).

The title differs in eglishn/german: 
Richtlinie: Updates (german)
Policy: Update (english)

And when opening the policy then there is a completely new title:
Automatische Updates (german)
Automatic updates (english)

I think this should be changed, too.
Comment 23 Florian Best univentionstaff 2015-01-19 16:51:36 CET
I fixed the things from comment #22 in svn r57372.
Comment 24 Alexander Kläser univentionstaff 2015-01-20 23:54:58 CET
(In reply to Florian Best from comment #23)
> I fixed the things from comment #22 in svn r57372.

YAML file: OK, minor adjustments [r57402]
Changes: OK
Package version: OK
Comment 25 Janek Walkenhorst univentionstaff 2015-01-22 11:56:22 CET
<http://errata.univention.de/ucs/4.0/43.html>