Bug 42801 - Implement backend routines for saving app changes
Implement backend routines for saving app changes
Status: CLOSED FIXED
Product: UCS
Classification: Unclassified
Component: App Center - Self Service
UCS 4.1
Other Linux
: P5 normal (vote)
: ---
Assigned To: Dirk Wiesenthal
:
Depends on: 43040
Blocks: 42635
  Show dependency treegraph
 
Reported: 2016-10-31 13:21 CET by Alexander Kläser
Modified: 2016-11-25 10:01 CET (History)
0 users

See Also:
What kind of report is it?: Development Internal
What type of bug is this?: ---
Who will be affected by this bug?: ---
How will those affected feel about the bug?: ---
User Pain:
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Kläser univentionstaff 2016-10-31 13:21:25 CET
On the backend side, we need a corresponding saving method which will update the App INI file, its images and README files.

JavaScript will send to the server process a JSON dict containing all fields that have been changed by the user. All images (SVG logos and PNG/JPEG screenshots) are base64 encoded.
Comment 1 Alexander Kläser univentionstaff 2016-10-31 17:06:42 CET
The app page already sends a save request to 'appcenter-selfservice/save' with all changes being made [r73918].
Comment 2 Dirk Wiesenthal univentionstaff 2016-11-07 02:09:56 CET
First implementation in r74143. save works. Some utility functions may be broken, but they will be fixed with another patch. Opening, saving, cloning should work (did not test cloning).

Not sure how translations, sizing works yet.
Comment 3 Alexander Kläser univentionstaff 2016-11-10 11:03:10 CET
We need a backend functionality to read/write just the meta file of an app.
Comment 4 Alexander Kläser univentionstaff 2016-11-10 11:04:23 CET
(In reply to Alexander Kläser from comment #3)
> We need a backend functionality to read/write just the meta file of an app.

This would be for Bug 42800.
Comment 5 Alexander Kläser univentionstaff 2016-11-10 12:12:22 CET
In the App page, settings are only saved when clicking 'Save'. This behaviour does not work for uploaded files, these are stored directly into the component, i.e., the user has no possibility to undo his changes. Therefore we need to store uploaded Debian files in a temporary folder (e.g. prefixed with the username + component_id) first. In the save action, uploaded files need then to be considered and moved to their final destination. Temporary files should be removed (e.g., via a cronjob or at-jobs) after some interval.
Comment 6 Dirk Wiesenthal univentionstaff 2016-11-17 23:57:48 CET
(In reply to Alexander Kläser from comment #5)
> In the App page, settings are only saved when clicking 'Save'. This
> behaviour does not work for uploaded files, these are stored directly into
> the component, i.e., the user has no possibility to undo his changes.
> Therefore we need to store uploaded Debian files in a temporary folder (e.g.
> prefixed with the username + component_id) first. In the save action,
> uploaded files need then to be considered and moved to their final
> destination. Temporary files should be removed (e.g., via a cronjob or
> at-jobs) after some interval.

This is Bug#42943
Comment 7 Alexander Kläser univentionstaff 2016-11-25 10:01:08 CET
The new version of the App Provider Portal has been released and this bug will thus be closed.