Bug 43327 – Allow to unset custom entries via advanced settings tab

Bug 43327 - Allow to unset custom entries via advanced settings tab


Summary:	Allow to unset custom entries via advanced settings tab

Status:	CLOSED FIXED

Product:	UCS
Classification:	Unclassified
Component:	App Center - Self Service
Version:	UCS 4.1
Hardware:	Other Linux

Importance:	P5 normal (vote)
Target Milestone:	---
Assigned To:	Jens Pelzetter
QA Contact:	Dirk Wiesenthal

URL:
Keywords:

Depends on:	42789
Blocks:	42635
	Show dependency tree / graph

Reported:	2017-01-11 13:05 CET by Alexander Kläser
Modified:	2019-01-08 17:19 CET (History)
CC List:	2 users (show)

See Also:
What kind of report is it?:	Bug Report
What type of bug is this?:	3: Simply Wrong: The implementation doesn't match the docu
Who will be affected by this bug?:	1: Will affect a very few installed domains
How will those affected feel about the bug?:	2: A Pain – users won’t like this once they notice it
User Pain:	0.034
Enterprise Customer affected?:
School Customer affected?:
ISV affected?:
Waiting Support:
Flags outvoted (downgraded) after PO Review:
Ticket number:
Bug group (optional):
Max CVSS v3 score:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alexander Kläser

2017-01-11 13:05:01 CET

(In reply to Dirk Wiesenthal from Bug 42789, comment #7)
> (In reply to Alexander Kläser from Bug 42789, comment #5)
> > > [...]
> > > * Custom entries (we need a list of INI fields which need to be displayed)
> > 
> > Done.
> 
> You cannot easily unset a custom entry. The frontend needs send
> {'mycustomkey': ''} if that custom entry was deleted via the [-] button.


+++ This bug was initially created as a clone of Bug #42789 +++

We will need a tab for handling further advanced settings. Herein, it will be also possible to define free key-value pairs that are currently not considered in the layout.

Comment 1 Jens Pelzetter

2018-12-04 12:04:27 CET

Custom entries can now unset when the entry is removed using the trash icon of the widget.  The same problem should occur with the categories and other MultiInput widgets on the AppPage.

Actually it was a combination of two problems: The variable containing the original values was initialized to early. The consequence was that the variables for the custom entries and the categories were empty. This was resolved by using the ready() function of the form. The second problem was that the #getChangedValues did not check for removed entries. This was also changed.

Comment 2 Dirk Wiesenthal

2019-01-08 17:19:13 CET

Works great. Already live