Univention Bugzilla – Bug 36291
Fine tuning of UMC design
Last modified: 2015-02-09 13:10:29 CET
+++ This bug was initially created as a clone of Bug #35654 +++ The UMC design should be revised with UCS 4.0.
Created attachment 6213 [details] vertical scrollbar MultiObjectSelect probably because of the checkboxes → they should be removed in MultiObjectSelect as they don't have a function there.
Created attachment 6214 [details] Users/user account tab - alignment MultiInput remove button
Created attachment 6215 [details] label pane of policies should be on top
Created attachment 6216 [details] alignment of add policy button
Created attachment 6217 [details] label pane of permission flags should be on top
Created attachment 6218 [details] margin-top on share-advanced settings tab
Created attachment 6219 [details] general alignment of printers and required flag on empty label panes
Created attachment 6220 [details] label pane of policies should be on top better screenshot for attachment 6215 [details]
Created attachment 6221 [details] nagios settings alignment
Created attachment 6222 [details] DHCP search input field
Created attachment 6223 [details] DNS alignment / size classes
Created attachment 6224 [details] policy reference button with iconClass
Created attachment 6225 [details] radiobutton text alignment → Bug #36321
labelPosition of Text, UnixAccessRights*, MultiInput has been moved into the 'top' → r54896
Created attachment 6226 [details] not indented
Created attachment 6227 [details] Bug #36457 checkbox under submit button
(In reply to Florian Best from comment #13) > Created attachment 6225 [details] > radiobutton text alignment This should be fine now.
(In reply to Florian Best from comment #11) > Created attachment 6223 [details] > DNS alignment / size classes Fixed. univention-management-console-frontend-theme (0.0.69-1): * Bug #36291: fixed handling of sizing for ComplexInput/MultiInput univention-management-console-frontend (4.1.73-1): * Bug #36291: fixed handling of sizing + labels for ComplexInput/MultiInput
(In reply to Florian Best from comment #7) > Created attachment 6219 [details] > general alignment of printers and required flag on empty label panes fixed.
(In reply to Florian Best from comment #9) > Created attachment 6221 [details] > nagios settings alignment fixed. univention-directory-manager-modules (10.0.20-1): Bug #36291 * adjust sizes of complex syntaxes * adjust layout of nagios/service UDM object
It seems that only the following issues remain. (In reply to Florian Best from comment #2) > Created attachment 6214 [details] > alignment MultiInput remove button MultiInput widget with large label: Could be fixed with a larger size or smaller text. IMHO no blocker. (In reply to Florian Best from comment #4) > Created attachment 6216 [details] > alignment of add policy button UDM add plolicy button. IMHO no blocker. (In reply to Florian Best from comment #12) > Created attachment 6224 [details] > policy reference button with iconClass UDM tab for policy reference: The icon is there, SVG is only too large. A background-size=16px would do the job, maybe something to add in general in umc/tools:getIconClass() for SVG graphics. We could also replace PNGs in the Grid with SVGs (I am not sure whether we have SVGs for all icons, though). This should be fixed, as well. (In reply to Florian Best from comment #15) > Created attachment 6226 [details] > not indented UCC wizard: The indentation + alignment is broken. This should be fixed (In reply to Florian Best from comment #16) > Created attachment 6227 [details] > checkbox under submit button Repository settings: The checkbox should go above the submit button. IMHO no blocker.
(In reply to Alexander Kläser from comment #21) > ... > (In reply to Florian Best from comment #15) > > Created attachment 6226 [details] > > not indented > > UCC wizard: The indentation + alignment is broken. > This should be fixed > ... I opened Bug 36373 for this part. The rest can be done as erratum.
From Bug 35654, comment #7: > Created attachment 6280 [details] > missing max-height for dialog Missing max-height property in UMC module "Software update".
Comment on attachment 6227 [details] Bug #36457 checkbox under submit button Bug #36457 was created for attachment 6227 [details] - marking it as obsolete to use that bug.
There is always a request to https://*/univention-management-console/js/dijit/themes/umc/images/spriteArrows.png which does not exists.
(In reply to Florian Best from comment #6) > Created attachment 6218 [details] > margin-top on share-advanced settings tab This might be correct by switching the CSS rule .umc .dijitTitlePane { margin-top: 3em; } to margin-bottom instead.
r56484 univention-management-console-frontend-theme (0.0.88-2) * Added max-height to the software update dialog * aligned buttons with inputfields in LabelPanes
YAML file entry: > * The Upgrade dialog in the "Software update" module now has an > maximum height. Suggestion: > * The dialogue showing the list of packages to be updated/installed > in the "Software update" module now is limited in its maximum height.
Another YAML entry: > * The warning if IE <= 8 is beeing used now lists all supported browsers. > If an outdated brwoser is beeing used a message will be shown in the > login dialog. A notification after the login will no longer show up. > * The icon on the policy reference button is now shown Minor adaptations and typo fixes: > * A warning is displayed when using Internet Explorer in version <= 8 > along with a list of all supported browsers. > * If an outdated browser is being used, a message will be shown in the > login dialogue. A notification after the login will no longer show up. > * The icon on the policy reference button is now shown.
r57204 univention-management-console-frontend-theme (0.0.88-4) Bug #36291: adjusted styling of the MultiObjectSelect so it adapts to to the width of the screen
Included YAML changes from comment #28 and comment #29
(In reply to Florian Best from comment #6) > Created attachment 6218 [details] > margin-top on share-advanced settings tab REOPEN: this is not done yet. The rest seems to be okay (did no code review).
(In reply to Florian Best from comment #6) > Created attachment 6218 [details] > margin-top on share-advanced settings tab Fixed: r57332 univention-management-console-frontend-theme (0.0.88-6) * Bug #36291: Changed margin-top for Titlepanes to margin-bottom
Most changes are really good! I just could spot minor things... (In reply to Alexander Kläser from comment #21) > ... > (In reply to Florian Best from comment #2) > > Created attachment 6214 [details] > > alignment MultiInput remove button > > MultiInput widget with large label: Could be fixed with a larger size or > smaller text. > IMHO no blocker. → OK, alignment of button has been adjust, this looks great! > (In reply to Florian Best from comment #4) > > Created attachment 6216 [details] > > alignment of add policy button > > UDM add plolicy button. > IMHO no blocker. → OK, change for the above problem fixes this, as well :) ! (In reply to Alexander Kläser from comment #21) > ... > (In reply to Florian Best from comment #12) > > Created attachment 6224 [details] > > policy reference button with iconClass > > UDM tab for policy reference: The icon is there, SVG is only too large. A > background-size=16px would do the job, maybe something to add in general in > umc/tools:getIconClass() for SVG graphics. We could also replace PNGs in the > Grid with SVGs (I am not sure whether we have SVGs for all icons, though). > This should be fixed, as well. → OK, icons look fine now, cool! (In reply to Alexander Kläser from comment #22) > (In reply to Alexander Kläser from comment #21) > > ... > > (In reply to Florian Best from comment #15) > > > Created attachment 6226 [details] > > > not indented > > > > UCC wizard: The indentation + alignment is broken. > > This should be fixed > > ... > > I opened Bug 36373 for this part. > The rest can be done as erratum. → OK, handled via Bug #36373. (In reply to Alexander Kläser from comment #21) > ... > (In reply to Florian Best from comment #16) > > Created attachment 6227 [details] > > checkbox under submit button > > Repository settings: The checkbox should go above the submit button. > IMHO no blocker. → OK, handled via Bug #36457. (In reply to Alexander Kläser from comment #23) > From Bug 35654, comment #7: > > Created attachment 6280 [details] > > missing max-height for dialog > > Missing max-height property in UMC module "Software update". Referring to r56484: +.umc .dijitDialogPaneContent .umcText { + max-height: 400px; + overflow: auto; + //white-space: pre; +} I think it is not a good idea to set a generic max-height on umcText elements. I this case, I would rather suggest to set the max-height property in the specific Text widget in the updater. → REOPEN (In reply to Florian Best from comment #25) > There is always a request to > https://*/univention-management-console/js/dijit/themes/umc/images/ > spriteArrows.png > which does not exists. → OK, seems to be fine, I could not find any erroneous requests. (In reply to Alexander Kläser from comment #26) > (In reply to Florian Best from comment #6) > > Created attachment 6218 [details] > > margin-top on share-advanced settings tab > > This might be correct by switching the CSS rule > > .umc .dijitTitlePane { > margin-top: 3em; > } > > to margin-bottom instead. Looks good, however, on the policies subtab there is now quite a lot of margin. Could you have a look at this, please (see screenshot below). → REOPEN (In reply to Johannes Keiser from comment #30) > r57204 > > univention-management-console-frontend-theme (0.0.88-4) > > Bug #36291: adjusted styling of the MultiObjectSelect so it adapts to > to the width of the screen Cool! The problem still persists for MultiSelect widgets (see screenshot below). Could you extend it for this widget? → REOPEN (In reply to Florian Best from comment #6) > Created attachment 6218 [details] > margin-top on share-advanced settings tab → OK, looks good.
(In reply to Alexander Kläser from comment #34) > ... > (In reply to Alexander Kläser from comment #23) > > From Bug 35654, comment #7: > > > Created attachment 6280 [details] > > > missing max-height for dialog > > > > Missing max-height property in UMC module "Software update". > > Referring to r56484: > +.umc .dijitDialogPaneContent .umcText { > + max-height: 400px; > + overflow: auto; > + //white-space: pre; > +} > > I think it is not a good idea to set a generic max-height on umcText > elements. I this case, I would rather suggest to set the max-height property > in the specific Text widget in the updater. > → REOPEN I opened Bug 37573, as this is updater specific.
> (In reply to Alexander Kläser from comment #26) > > (In reply to Florian Best from comment #6) > > > Created attachment 6218 [details] > > > margin-top on share-advanced settings tab > > > > This might be correct by switching the CSS rule > > > > .umc .dijitTitlePane { > > margin-top: 3em; > > } > > > > to margin-bottom instead. > > Looks good, however, on the policies subtab there is now quite a lot of > margin. Could you have a look at this, please (see screenshot below). > → REOPEN > > (In reply to Johannes Keiser from comment #30) > > r57204 > > > > univention-management-console-frontend-theme (0.0.88-4) > > > > Bug #36291: adjusted styling of the MultiObjectSelect so it adapts to > > to the width of the screen > > Cool! The problem still persists for MultiSelect widgets (see screenshot > below). Could you extend it for this widget? > → REOPEN > Fixed: r57452 univention-management-console-frontend-theme (0.0.88-7) * removed margin-bottom for the last-child of the TitlePanes * adjusted sytling of MultiSelect box so it adapts to the width of the screen YAML: r57453
(In reply to Alexander Kläser from comment #34) > ... > Referring to r56484: > +.umc .dijitDialogPaneContent .umcText { > + max-height: 400px; > + overflow: auto; > + //white-space: pre; > +} > > I think it is not a good idea to set a generic max-height on umcText > elements. I this case, I would rather suggest to set the max-height property > in the specific Text widget in the updater. > → REOPEN → OK, has been reverted > ... > (In reply to Alexander Kläser from comment #26) > > (In reply to Florian Best from comment #6) > > > Created attachment 6218 [details] > > > margin-top on share-advanced settings tab > > > > This might be correct by switching the CSS rule > > > > .umc .dijitTitlePane { > > margin-top: 3em; > > } > > > > to margin-bottom instead. > > Looks good, however, on the policies subtab there is now quite a lot of > margin. Could you have a look at this, please (see screenshot below). > → REOPEN → OK... I forgot to add the screenshot, ehem... but this is not critical at the moment. > (In reply to Johannes Keiser from comment #30) > > r57204 > > > > univention-management-console-frontend-theme (0.0.88-4) > > > > Bug #36291: adjusted styling of the MultiObjectSelect so it adapts to > > to the width of the screen > > Cool! The problem still persists for MultiSelect widgets (see screenshot > below). Could you extend it for this widget? > → REOPEN → OK, the rules for .umcMultiObjectSelect and .umcMultiSelect could be merged if I am correct. They have been copied & pasted. But that is OK for now. The changes were not committed to the git repository that is tracked within the SVN repository, as well. However, as this complicates the development process, I removed the .git directory from the SVN. This should simplify the work with the UMC theme [r57479].
Changes: OK YAML entries: OK Package version: OK
Created attachment 6634 [details] screenshot The changes cause the issue in the screenshot when having AD-Mode enabled.
(In reply to Florian Best from comment #39) > Created attachment 6634 [details] > screenshot > > The changes cause the issue in the screenshot when having AD-Mode enabled. fixed: r57594 univention-management-console-module-udm (5.1.25-42) * Bug #36291: Adjusted margin for UDMDetailPageWarning to accommodate to style changes for TitlePane ---------- (In reply to Alexander Kläser from comment #37) > (In reply to Alexander Kläser from comment #34) . . > → OK, the rules for .umcMultiObjectSelect and .umcMultiSelect could be > merged if I am correct. They have been copied & pasted. But that is OK for > now. r57602 univention-management-console-frontend-theme (0.0.88-8) removed style for umcMultiObjectSelect since umcMultiSelect is within umcMultiObjectSelect
OK: both changes are fine
<http://errata.univention.de/ucs/4.0/50.html>
<http://errata.univention.de/ucs/4.0/62.html>
<http://errata.univention.de/ucs/4.0/51.html>